New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime, cmd/link: darwin/amd64 occasionally hangs #25181
Comments
I suspect this darwin/amd64 failure from the dashboard is the same thing: https://build.golang.org/log/16b7534fc8d85a751999df12ffb24f7eb825e79a |
Change https://golang.org/cl/110123 mentions this issue: |
CL 110123 already out for the arm64 fix. |
Missed conversion of newosproc for the parts of darwin that weren't affected by my previous change. Update #25181 Change-Id: I81a2935e192b6d0df358c59b7e785eb03c504c23 Reviewed-on: https://go-review.googlesource.com/110123 Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
Change https://golang.org/cl/111258 mentions this issue: |
A few libc_ calls were missing stack switches. Unfortunately, adding the stack switches revealed a deeper problem. systemstack() is fundamentally flawed because when you do systemstack(func() { ... }) There's no way to mark the anonymous function as nosplit. At first I thought it didn't matter, as that function runs on the g0 stack. But nosplit is still required, because some syscalls are done when stack bounds are not set up correctly (e.g. in a signal handler, which runs on the g0 stack, but g is still pointing at the g stack). Instead use asmcgocall and funcPC, so we can be nosplit all the way down. Mid-stack inlining now pushes darwin over the nosplit limit also. Leaving that as a TODO. Update #23168 This might fix the cause of occasional darwin hangs. Update #25181 Update #17490 Change-Id: If9c3ef052822c7679f5a1dd192443f714483327e Reviewed-on: https://go-review.googlesource.com/111258 Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
Is this still a problem? |
I haven’t experienced it in a while. Closing until proven otherwise. |
https://golang.org/cl/108679 seems to have broken the darwin/arm and darwin/arm64 builds.
Also, I am now experiencing occasional hangs during make.bash. Sample SIGQUIT output:
cc @randall77
The text was updated successfully, but these errors were encountered: