-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crypto/tls/generate_cert.go: Organization name and file names #25157
Comments
What is your use case? |
Can be made backward compatibel by using does entries above as default. My use case is to generate certificates for testing grpc services. Where organisation need to be localhost or a specific company name, and file names tls.key, tls.crt. I can copy this file and modify it but I think this go file can fill in plenty of test cases if does 3 fields have flags too. |
This has been brought up before and I doubt the Go team is willing to support changes to make this a dependency for folks. It's easy enough to copy the code elsewhere. See: #19900 (comment) |
Still think it helps promote the use of tls more if you make it easier for a user to generate certificates without the need of copying or use of a third party repo. Also if for some reason a security bug is found in that code, which is highly unlikely I know, but it gives a fail safe for the users to get fixed immediately. |
|
https://golang.org/src/crypto/tls/generate_cert.go
Can we have 3 more flags please for
It will be more flexible for building scripts that can then use it directly instead of modifying a copy of that file.
The text was updated successfully, but these errors were encountered: