Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/crypto/blake2b: test build fails #25098

Closed
kevinburke opened this issue Apr 26, 2018 · 3 comments
Closed

x/crypto/blake2b: test build fails #25098

kevinburke opened this issue Apr 26, 2018 · 3 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@kevinburke
Copy link
Contributor

kevinburke commented Apr 26, 2018 •
edited

Please answer these questions before submitting your issue. Thanks!

What did you do?

Compile Go at tip (58c231f)

cd $GOPATH/src/golang.org/x/crypto
git pull origin master # (golang/crypto@b0697eccbea9adec5b7ba8008f4c33d98d733388)
go test ./blake2b

What did you expect to see?

Test pass (or test failure)

What did you see instead?

Compile failure:

$ go test ./blake2b
# golang.org/x/crypto/blake2b.test
golang.org/x/crypto/blake2b.supportsAVX2: relocation target runtime.support_avx2 not defined
golang.org/x/crypto/blake2b.supportsAVX: relocation target runtime.support_avx not defined
golang.org/x/crypto/blake2b.supportsAVX2: undefined: "runtime.support_avx2"
golang.org/x/crypto/blake2b.supportsAVX: undefined: "runtime.support_avx"
FAIL	golang.org/x/crypto/blake2b [build failed]

Does this issue reproduce with the latest release (go1.10.1)?

No. It also does not reproduce with go build ./blake2b.

System details

go version devel +58c231f244 Thu Apr 26 03:54:19 2018 +0000 darwin/amd64
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/kevin/Library/Caches/go-build"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/kevin"
GORACE=""
GOROOT="/Users/kevin/go"
GOTMPDIR=""
GOTOOLDIR="/Users/kevin/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/sf/fsn3_vgd0n98r0jb86bgp83r0000gn/T/go-build178385163=/tmp/go-build -gno-record-gcc-switches -fno-common"
GOROOT/bin/go version: go version devel +58c231f244 Thu Apr 26 03:54:19 2018 +0000 darwin/amd64
GOROOT/bin/go tool compile -V: compile version devel +58c231f244 Thu Apr 26 03:54:19 2018 +0000
uname -v: Darwin Kernel Version 17.5.0: Mon Mar  5 22:24:32 PST 2018; root:xnu-4570.51.1~1/RELEASE_X86_64
ProductName:	Mac OS X
ProductVersion:	10.13.4
BuildVersion:	17E199
lldb --version: lldb-900.0.57
  Swift-4.0
@gopherbot gopherbot added this to the Unreleased milestone Apr 26, 2018
@agnivade
Copy link
Contributor

This is because of https://go-review.googlesource.com/c/crypto/+/108795 and #24828

@gopherbot
Copy link

Change https://golang.org/cl/110016 mentions this issue: blake2b: stub out values removed from runtime

@bcmills bcmills added the NeedsFix The path to resolution is known, but the work has not been done. label Apr 27, 2018
@bcmills bcmills modified the milestones: Unreleased, Go1.11 Apr 27, 2018
@FiloSottile
Copy link
Contributor

Fixed by golang/crypto@ae8bce0.

@titaniumbones titaniumbones mentioned this issue Oct 29, 2018
Closed
@max-k max-k mentioned this issue Nov 4, 2018
Closed
@golang golang locked and limited conversation to collaborators Apr 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@kevinburke @FiloSottile @agnivade @bcmills @gopherbot