Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc/cgo/test: TestSigprocmask is flaky on s390x #25078

Closed
bcmills opened this issue Apr 25, 2018 · 5 comments
Closed

misc/cgo/test: TestSigprocmask is flaky on s390x #25078

bcmills opened this issue Apr 25, 2018 · 5 comments
Labels
FrozenDueToAge help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Go1.11

Comments

@bcmills
Copy link
Contributor

bcmills commented Apr 25, 2018

The last two s390x failures1 2 on https://build.golang.org are from the same test, and occurred several runs apart. It's not obvious to me whether the bug is in the test, the s390x port, or elsewhere.

##### ../misc/cgo/test
PASS
ok  	_/data/golang/workdir/go/misc/cgo/test	2.573s
--- FAIL: TestSigprocmask (0.00s)
	sigprocmask.go:35: pthread_create/pthread_join failed
	sigprocmask.go:38: Go runtime unblocked SIGIO
FAIL
exit status 1
FAIL	_/data/golang/workdir/go/misc/cgo/test	2.588s
2018/04/24 23:13:09 Failed: exit status 1

(CC: @mundaym)
@bcmills bcmills added help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Apr 25, 2018
@bcmills bcmills added this to the Go1.11 milestone Apr 25, 2018
@bcmills bcmills changed the title misc/cgo/test: TestSigprocMask is flaky on s390x misc/cgo/test: TestSigprocmask is flaky on s390x Apr 25, 2018
@gopherbot
Copy link

Change https://golang.org/cl/109359 mentions this issue: misc/cgo/test: log error value in testSigprocmask

gopherbot pushed a commit that referenced this issue Apr 25, 2018
@ianlancetaylor
misc/cgo/test: log error value in testSigprocmask
9c9ed9a 
The test has been flaky, probably due to EAGAIN, but let's find out
for sure.

Updates #25078

Change-Id: I5a5b14bfc52cb43f25f07ca7d207b61ae9d4f944
Reviewed-on: https://go-review.googlesource.com/109359
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
@ianlancetaylor
Copy link
Contributor

Occurrences:

2018-02-26T05:04:31-e9c57be/linux-s390x-ibm
2018-02-26T10:27:14-dd3b471/linux-s390x-ibm
2018-02-26T17:02:29-9cae3aa/linux-s390x-ibm
2018-02-26T23:49:44-4b00d3f/linux-s390x-ibm
2018-02-27T16:29:17-f399af3/linux-s390x-ibm
2018-02-27T18:37:36-2013ad8/linux-s390x-ibm
2018-02-27T20:06:22-15b0d13/linux-s390x-ibm
2018-02-28T22:09:34-413d8a8/linux-s390x-ibm
2018-02-28T23:28:39-0942584/linux-s390x-ibm
2018-03-01T00:16:20-4338518/linux-s390x-ibm
2018-03-01T18:51:44-c15984c/linux-s390x-ibm
2018-03-01T22:06:03-f1fc9da/linux-s390x-ibm
2018-03-02T18:55:56-9dc351b/linux-s390x-ibm
2018-03-02T20:32:08-d3562c9/linux-s390x-ibm
2018-03-04T01:05:02-80bfb75/linux-s390x-ibm
2018-03-04T16:52:03-fad31e5/linux-s390x-ibm
2018-03-07T16:12:08-aa00d97/linux-s390x-ibm
2018-03-07T16:41:24-c028958/linux-s390x-ibm
2018-03-07T23:35:25-419c064/linux-s390x-ibm
2018-03-08T03:26:22-0add9a4/linux-s390x-ibm
2018-03-08T14:17:34-5b14c7b/linux-s390x-ibm
2018-03-08T22:25:24-2e9cf5f/linux-s390x-ibm
2018-03-08T22:55:52-7f1b273/linux-s390x-ibm
2018-03-08T22:55:55-60a9e5d/linux-s390x-ibm
2018-03-09T00:33:43-2cc15b1/linux-s390x-ibm
2018-03-10T00:33:10-f69ad10/linux-s390x-ibm
2018-03-12T18:01:33-080187f/linux-s390x-ibm
2018-03-20T22:46:00-5f0a9ba/linux-s390x-ibm
2018-03-29T06:07:26-e1c0834/linux-s390x-ibm
2018-04-11T23:06:44-044d2d5/linux-s390x-ibm
2018-04-20T01:40:35-9f10d28/linux-s390x-ibm
2018-04-24T01:06:17-a3c75d9/linux-s390x-ibm
2018-04-25T02:49:10-09d36a8/linux-s390x-ibm
2018-04-27T20:52:20-93cfaa0/linux-s390x-ibm
2018-05-08T17:16:30-25858cc/linux-s390x-ibm
2018-05-09T14:46:40-f31a132/linux-s390x-ibm
2018-05-21T18:42:00-b88276d/linux-s390x-ibm
2018-05-23T16:55:51-0979767/linux-s390x-ibm
2018-05-23T18:18:39-7ba1c91/linux-s390x-ibm
2018-05-25T16:49:28-8875693/linux-s390x-ibm
2018-06-10T05:49:55-a5f8303/linux-s390x-ibm
2018-06-11T06:35:20-679690f/linux-s390x-ibm
2018-06-14T21:50:53-e083dc6/linux-s390x-ibm
2018-06-18T22:03:17-17a4e04/linux-s390x-ibm
2018-06-19T22:19:28-65d55a1/linux-s390x-ibm
2018-06-20T02:52:44-29673a4/linux-s390x-ibm
2018-06-21T19:35:27-1507502/linux-s390x-ibm
2018-06-25T20:01:45-6d70952/linux-s390x-ibm
2018-06-26T14:41:15-d89efc3/linux-s390x-ibm
2018-06-26T16:40:09-8997ec1/linux-s390x-ibm

@ianlancetaylor
Copy link
Contributor

The error is that either pthread_create or pthread_join is returning EAGAIN.

@gopherbot
Copy link

Change https://golang.org/cl/121096 mentions this issue: misc/cgo/test: add retry loop around pthread_create in TestSigprocmask

@ianlancetaylor
Copy link
Contributor

Sending CL 121096 which should fix this problem. If not, we can reopen.

@golang golang locked and limited conversation to collaborators Jun 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Go1.11
Development

No branches or pull requests
3 participants
@ianlancetaylor @bcmills @gopherbot