Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/vgo: vgo depends on as-yet-unmerged cmd/go/internal/modfetch/gitrepo #25062

Closed
flibustenet opened this issue Apr 25, 2018 · 6 comments
Closed

x/vgo: vgo depends on as-yet-unmerged cmd/go/internal/modfetch/gitrepo #25062

flibustenet opened this issue Apr 25, 2018 · 6 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
vgo

Comments

@flibustenet
Copy link

What operating system and processor architecture are you using (go env)?

go version go1.10.1 linux/amd64

What did you do?

go get -u golang.org/x/vgo

What did you see instead?

package cmd/go/internal/modfetch/gitrepo: unrecognized import path "cmd/go/internal/modfetch/gitrepo" (import path does not begin with hostname)
@gopherbot gopherbot added this to the vgo milestone Apr 25, 2018
@myitcv
Copy link
Member

myitcv commented Apr 25, 2018

cc @rsc - not sure how the trybots passed here.... because downloading https://go-review.googlesource.com/c/vgo/+/107657 locally failed for me:

cd $(go list -f "{{.Dir}}" golang.org/x/vgo)
git fetch https://go.googlesource.com/vgo refs/changes/57/107657/3 && git checkout FETCH_HEAD
go install

gives:

vendor/cmd/go/internal/modfetch/bitbucket/fetch.go:12:2: cannot find package "cmd/go/internal/modfetch/gitrepo" in any of:
        /home/myitcv/gostuff/src/golang.org/x/vgo/vendor/cmd/go/internal/modfetch/gitrepo (vendor tree)
        /home/myitcv/gos/src/cmd/go/internal/modfetch/gitrepo (from $GOROOT)
        /home/myitcv/gostuff/src/cmd/go/internal/modfetch/gitrepo (from $GOPATH)

@myitcv
Copy link
Member

myitcv commented Apr 25, 2018

cc @bcmills too

@myitcv myitcv changed the title x/vgo Cannot go get current vgo today x/vgo: vgo depends on as-yet-unmerged cmd/go/internal/modfetch/gitrepo Apr 25, 2018
@mvdan mvdan added the NeedsFix The path to resolution is known, but the work has not been done. label Apr 25, 2018
@oiooj
Copy link
Member

oiooj commented Apr 25, 2018

It seems that it need CL https://go-review.googlesource.com/c/vgo/+/107656 merged first.

@rsc
Copy link
Contributor

rsc commented Apr 25, 2018

Sorry. We'll get there.

@rsc
Copy link
Contributor

rsc commented Apr 25, 2018

https://go-review.googlesource.com/c/vgo/+/107656 is now submitted,
along with the important fix https://go-review.googlesource.com/c/vgo/+/109336.

@rsc rsc closed this as completed Apr 25, 2018
@myitcv
Copy link
Member

myitcv commented Apr 25, 2018

Thanks - is it significant or not that the trybots passed for this, despite the build error?

(I actually have no idea where to look to see what they're "try"-ing)

@golang golang locked and limited conversation to collaborators Apr 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
vgo
Development

No branches or pull requests
6 participants
@rsc @oiooj @myitcv @mvdan @flibustenet @gopherbot