Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/go/gcexportdata: broken tests since CL 106797 #25052

Closed
FiloSottile opened this issue Apr 24, 2018 · 8 comments
Closed

x/tools/go/gcexportdata: broken tests since CL 106797 #25052

FiloSottile opened this issue Apr 24, 2018 · 8 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.11

Comments

@FiloSottile
Copy link
Contributor

https://go-review.googlesource.com/c/go/+/106797 broke golang.org/x/tools/go/gcexportdata and some other tests in x/tools.

https://build.golang.org/?repo=golang.org%2fx%2ftools

https://build.golang.org/log/6b1bda36613153b5c4fe514d34c2b351a38eeae9
@FiloSottile FiloSottile changed the title golang.org/x/tools/go/gcexportdata: broken tests since CL 106797 x/tools/go/gcexportdata: broken tests since CL 106797 Apr 24, 2018
@gopherbot gopherbot added this to the Unreleased milestone Apr 24, 2018
@FiloSottile FiloSottile added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 24, 2018
@mdempsky
Copy link
Member

This just requires backporting go/internal/gcimporter/iimport.go to the x/tools repo.

/cc @griesemer @alandonovan for FYI

@dsnet
Copy link
Member

dsnet commented Apr 26, 2018 •
edited

@mdempsky, are you still working on getting this back-ported? Part of the tip regression testing process relies upon the tools repo, which seems to rely on this getting fixed as well.

@bcmills bcmills added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Apr 26, 2018
@bcmills
Copy link
Contributor

bcmills commented Apr 26, 2018

@mdempsky, are you planning to fix this? The x/tools repo is currently still broken.

Should we roll back https://golang.org/cl/106797 in the meantime?

@alandonovan
Copy link
Contributor

Rebecca has agreed to look into this.

@bradfitz
Copy link
Contributor

bradfitz commented Apr 26, 2018 •
edited

This isn't milestone "Unreleased". Build breakages should be fixed soon because they impact everybody else trying to run tests in that tree. I'll retarget this to Go 1.11 and send a test to disable those tests in the meantime.

@bradfitz bradfitz modified the milestones: Unreleased, Go1.11 Apr 26, 2018
@FiloSottile
Copy link
Contributor Author

I think this is what the rarely-used Soon is for?

@bradfitz
Copy link
Contributor

We don't use Soon and I think we should delete it and replace it with a label if anything.

@gopherbot
Copy link

Change https://golang.org/cl/109595 mentions this issue: go/internal/gcimporter: support indexed export data

@LawnGnome LawnGnome mentioned this issue Apr 27, 2018
Closed
@golang golang locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.11
Development

No branches or pull requests
8 participants
@bradfitz @mdempsky @FiloSottile @bcmills @stamblerre @dsnet @alandonovan @gopherbot