New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/tools/go/gcexportdata: broken tests since CL 106797 #25052
Comments
This just requires backporting go/internal/gcimporter/iimport.go to the x/tools repo. /cc @griesemer @alandonovan for FYI |
@mdempsky, are you still working on getting this back-ported? Part of the tip regression testing process relies upon the tools repo, which seems to rely on this getting fixed as well. |
@mdempsky, are you planning to fix this? The Should we roll back https://golang.org/cl/106797 in the meantime? |
Rebecca has agreed to look into this. |
This isn't milestone "Unreleased". Build breakages should be fixed soon because they impact everybody else trying to run tests in that tree. I'll retarget this to Go 1.11 and send a test to disable those tests in the meantime. |
I think this is what the rarely-used Soon is for? |
We don't use Soon and I think we should delete it and replace it with a label if anything. |
Change https://golang.org/cl/109595 mentions this issue: |
https://go-review.googlesource.com/c/go/+/106797 broke golang.org/x/tools/go/gcexportdata and some other tests in x/tools.
https://build.golang.org/?repo=golang.org%2fx%2ftools
https://build.golang.org/log/6b1bda36613153b5c4fe514d34c2b351a38eeae9
The text was updated successfully, but these errors were encountered: