Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: install -linkshared invokes link commands for existing .so files since go1.10 [1.10 backport] #25044

Closed
gopherbot opened this issue Apr 24, 2018 · 3 comments
Closed

cmd/go: install -linkshared invokes link commands for existing .so files since go1.10 [1.10 backport] #25044

gopherbot opened this issue Apr 24, 2018 · 3 comments
Labels
CherryPickCandidate Used during the release process for point releases FrozenDueToAge
Milestone
Go1.10.7

Comments

@gopherbot
Copy link

@FiloSottile requested issue #24034 to be considered for backport to the next 1.10 minor release.

@gopherbot please open a backport tracking issue, as this is a 1.10 regression, although just a performance one.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Apr 24, 2018
@gopherbot gopherbot mentioned this issue Apr 24, 2018
Closed
@gopherbot gopherbot added this to the Go1.10.2 milestone Apr 24, 2018
@andybons andybons modified the milestones: Go1.10.2, Go1.10.3 Apr 27, 2018
@FiloSottile FiloSottile modified the milestones: Go1.10.3, Go1.10.4 Jun 7, 2018
@andybons andybons modified the milestones: Go1.10.4, Go1.10.5 Aug 24, 2018
@katiehockman
Copy link
Contributor

Approved since this is a regression. Please follow the instructions at https://github.com/golang/go/wiki/MinorReleases to create the cherrypick CL.

@katiehockman katiehockman added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Oct 29, 2018
@katiehockman
Copy link
Contributor

Removed the approved label since the original CL has not been merged yet. Once it is, and the issue is closed, this can be re-approved assuming it is still appropriate for backport.

@katiehockman katiehockman added CherryPickCandidate Used during the release process for point releases and removed CherryPickApproved Used during the release process for point releases labels Oct 30, 2018
@dmitshur dmitshur modified the milestones: Go1.10.5, Go1.10.6 Nov 1, 2018
@dmitshur dmitshur modified the milestones: Go1.10.6, Go1.10.7 Dec 13, 2018
@FiloSottile
Copy link
Contributor

This will not be fixed in 1.12, so definitely not backported to 1.10.

@golang golang locked and limited conversation to collaborators Dec 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickCandidate Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.10.7
Development

No branches or pull requests
5 participants
@andybons @FiloSottile @dmitshur @gopherbot @katiehockman