Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugin: net/http.Get fatals with "runtime: unexpected return pc for runtime.goexit called" [1.10 backport] #25038

Closed
gopherbot opened this issue Apr 24, 2018 · 3 comments
Closed

plugin: net/http.Get fatals with "runtime: unexpected return pc for runtime.goexit called" [1.10 backport] #25038

gopherbot opened this issue Apr 24, 2018 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.10.5

Comments

@gopherbot
Copy link

@FiloSottile requested issue #23133 to be considered for backport to the next 1.10 minor release.

@gopherbot please open a 1.10 backport tracking issue. Go 1.10.1 only included a partial fix.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Apr 24, 2018
@gopherbot gopherbot mentioned this issue Apr 24, 2018
Closed
@gopherbot gopherbot added this to the Go1.10.2 milestone Apr 24, 2018
@andybons andybons modified the milestones: Go1.10.2, Go1.10.3 Apr 27, 2018
@FiloSottile FiloSottile modified the milestones: Go1.10.3, Go1.10.4 Jun 7, 2018
@odeke-em
Copy link
Member

Please see @cherrymui's comment in #23133 (comment) /cc @randall77 too

@andybons andybons modified the milestones: Go1.10.4, Go1.10.5 Aug 24, 2018
@gopherbot
Copy link
Author

Change https://golang.org/cl/122116 mentions this issue: [release-branch.go1.10] cmd/link: put runtime.framepointer_enabled in DATA instead of RODATA

@andybons andybons added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Oct 29, 2018
@gopherbot
Copy link
Author

Closed by merging 1f8a5b8 to release-branch.go1.10.

gopherbot pushed a commit that referenced this issue Oct 29, 2018
@cherrymui @andybons
[release-branch.go1.10] cmd/link: put runtime.framepointer_enabled in…
1f8a5b8 
… DATA instead of RODATA

On darwin, only writable symbol is exported
(cmd/link/internal/ld/macho.go:/machoShouldExport).
For plugin to work correctly, global variables, including
runtime.framepointer_enabled which is set by the linker, need
to be exported when dynamic linking. Put it in DATA so it is
exported. Also in Go it is defined as a var, which is not
read-only.

While here, do the same for runtime.goarm.

Fixes #25038.

Change-Id: I9d1b7d5a648be17103d20b97be65a901cb69f5a2
Reviewed-on: https://go-review.googlesource.com/104715
Run-TryBot: Cherry Zhang <cherryyz@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Austin Clements <austin@google.com>
Reviewed-on: https://go-review.googlesource.com/c/122116
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.10.5
Development

No branches or pull requests
4 participants
@andybons @FiloSottile @odeke-em @gopherbot