Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/test2json: misparses subtest names with : in them [1.10 backport] #25027

Closed
gopherbot opened this issue Apr 23, 2018 · 1 comment
Closed

cmd/test2json: misparses subtest names with : in them [1.10 backport] #25027

gopherbot opened this issue Apr 23, 2018 · 1 comment
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.10.2

Comments

@gopherbot
Copy link

@andybons requested issue #23920 to be considered for backport to the next 1.10 minor release.

@gopherbot please backport
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Apr 23, 2018
@gopherbot gopherbot mentioned this issue Apr 23, 2018
Closed
@gopherbot gopherbot added this to the Go1.10.2 milestone Apr 23, 2018
@andybons andybons added the CherryPickApproved Used during the release process for point releases label Apr 23, 2018
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Apr 23, 2018
@gopherbot
Copy link
Author

Change https://golang.org/cl/110075 mentions this issue: [release-branch.go1.10] cmd/internal/test2json: support subtests containing colons

gopherbot pushed a commit that referenced this issue Apr 27, 2018
@mvdan @andybons
[release-branch.go1.10] cmd/internal/test2json: support subtests cont…
f26ed07 
…aining colons

The "updates" lines, such as RUN, do not contain a colon. However,
test2json looked for one anyway, meaning that it would be thrown off if
it encountered a line like:

	=== RUN   TestWithColons/[::1]

In that case, it must not use the first colon it encounters to separate
the action from the test name.

Fixes #25027

Change-Id: I82eff23e24b83dae183c0cf9f85fc5f409f51c25
Reviewed-on: https://go-review.googlesource.com/98445
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
(cherry picked from commit 0c5cfec)
Reviewed-on: https://go-review.googlesource.com/110075
Run-TryBot: Andrew Bonventre <andybons@golang.org>
@golang golang locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.10.2
Development

No branches or pull requests
2 participants
@andybons @gopherbot