Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gerritbot: some pull requests are neither imported nor closed #25020

Closed
ALTree opened this issue Apr 23, 2018 · 1 comment
Closed

x/build/cmd/gerritbot: some pull requests are neither imported nor closed #25020

ALTree opened this issue Apr 23, 2018 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@ALTree
Copy link
Member

ALTree commented Apr 23, 2018

In #24938 a contributor sent a pull request against release-branch.go1.9. Gopherbot didn't import it into gerrit, but it also didn't close it.

If sending changes to the release branches is not something that is supposed to work, the bot should warn the author about that and then close the pull request.

cc @andybons
@gopherbot gopherbot added this to the Unreleased milestone Apr 23, 2018
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Apr 23, 2018
@ALTree ALTree added the NeedsFix The path to resolution is known, but the work has not been done. label Apr 23, 2018
This was referenced Jul 10, 2020
Closed
Open
@dmitshur
Copy link
Contributor

dmitshur commented Jul 13, 2020 •
edited

The current behavior is that GopherBot will import PRs into Gerrit for any target branch (see #40190 and https://go-review.googlesource.com/c/go/+/242279 for a recent example). However, it's still not possible to make cherry-pick CLs via PRs because of another problem, see #30037.

This is documented in the last paragraph of https://golang.org/wiki/MinorReleases#making-cherry-pick-cls:

At this time, it's not possible to make a cherry-pick CL by sending a Pull Request. Only Gerrit is supported. See golang.org/issue/30037.

Let's use #30037 to track further improvements.

@golang golang locked and limited conversation to collaborators Jul 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@dmitshur @ALTree @gopherbot