Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/webdav: incorrect timestamp returned for getlastmodified #25015

Closed
go-d opened this issue Apr 23, 2018 · 3 comments
Closed

x/net/webdav: incorrect timestamp returned for getlastmodified #25015

go-d opened this issue Apr 23, 2018 · 3 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@go-d
Copy link

go-d commented Apr 23, 2018

In webdav/prop.go: fi.ModTime().Format(http.TimeFormat) gives GMT, but doesn't convert it to UTC time zone first.

Fix: fi.ModTime().UTC().Format(http.TimeFormat)
@gopherbot gopherbot added this to the Unreleased milestone Apr 23, 2018
@FiloSottile FiloSottile added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 24, 2018
@FiloSottile
Copy link
Contributor

/cc @nigeltao (? unclear if still the code owner)

@nigeltao
Copy link
Contributor

@bradfitz

@bradfitz bradfitz self-assigned this May 18, 2018
@gopherbot
Copy link

Change https://golang.org/cl/113795 mentions this issue: webdav: convert to UTC before using http.TimeFormat

@golang golang locked and limited conversation to collaborators May 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@bradfitz @FiloSottile @nigeltao @gopherbot @go-d