Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/godoc: front page video does not respond to layout changes #24997

Closed
jimmyfrasche opened this issue Apr 22, 2018 · 3 comments
Closed
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@jimmyfrasche
Copy link
Member

The video on the front page is always the width that makes sense on the widest layout. At some viewport widths this can cause it to overlap text and on others it's just unnecessarily tiny.

Fix incoming, cc @andybons

@gopherbot gopherbot added this to the Unreleased milestone Apr 22, 2018
@gopherbot
Copy link

Change https://golang.org/cl/108677 mentions this issue: x/tools/godoc: make front page video respond to layout changes (1/2)

@gopherbot
Copy link

Change https://golang.org/cl/108678 mentions this issue: x/tools/godoc: make front page video respond to layout changes (2/2)

@FiloSottile FiloSottile added the NeedsFix The path to resolution is known, but the work has not been done. label Apr 24, 2018
gopherbot pushed a commit to golang/tools that referenced this issue May 8, 2018
This part of a multi-repo change. See CL 108677 for details.

Note: this change also requires a CL to golang/go to complete the fix,
though either CL without the other is harmless.

Updates golang/go#24997.

Change-Id: I99ca9a4e6df16347b8706f24cef9689b3345854a
Reviewed-on: https://go-review.googlesource.com/108678
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Andrew Bonventre <andybons@golang.org>
gopherbot pushed a commit that referenced this issue May 8, 2018
The videos on the front page are always the same width, regardless of
the viewport width. These changes let the video fill the space given
to its container regardless of layout. It uses the standard hack for
making iframes responsive, but the videos are loaded at random and do
not have uniform aspect ratios so that information is injected into the
DOM using custom properties. If these are not supported, it falls back
to the same layout present before this change.

Note: this change also requires CL 108678 to complete the fix,
though either CL without the other is harmless.

Updates #24997.

Change-Id: I2f93dc21ffe01d99ce0e175e9dd0e3d486fddc9f
Reviewed-on: https://go-review.googlesource.com/108677
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Andrew Bonventre <andybons@golang.org>
@jimmyfrasche
Copy link
Member Author

With both CLs committed, this issue is fixed.

@golang golang locked and limited conversation to collaborators May 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

3 participants