Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime/pprof: slice bounds out of range builder failure #24991

Closed
mvdan opened this issue Apr 22, 2018 · 5 comments
Closed

runtime/pprof: slice bounds out of range builder failure #24991

mvdan opened this issue Apr 22, 2018 · 5 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@mvdan
Copy link
Member

mvdan commented Apr 22, 2018

Spotted on a linux-mipsle builder: https://build.golang.org/log/179ddea544b874db48141b2b327310dbab94385e

@mvdan mvdan added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 22, 2018
@mvdan mvdan added this to the Go1.11 milestone Apr 22, 2018
@odeke-em
Copy link
Member

Thank you for the report @mvdan!

/cc @aclements @MIPSbkirby @rsc

@ianlancetaylor ianlancetaylor modified the milestones: Go1.11, Go1.12 Jun 28, 2018
@gopherbot
Copy link

Change https://golang.org/cl/121515 mentions this issue: runtime: throw if the runtime panics

gopherbot pushed a commit that referenced this issue Jun 29, 2018
If the runtime code panics due to a bad index or slice expression,
then throw instead of panicing. This will skip calls to recover and dump
the entire runtime stack trace. The runtime should never panic due to
an out of bounds index, and this will help with debugging if it does.

For #24991
Updates #25201

Change-Id: I85a9feded8f0de914ee1558425931853223c0514
Reviewed-on: https://go-review.googlesource.com/121515
Reviewed-by: Austin Clements <austin@google.com>
@andybons andybons modified the milestones: Go1.12, Go1.13 Feb 12, 2019
@gopherbot
Copy link

Change https://golang.org/cl/184163 mentions this issue: runtime: add debugging print on crash in pprof

@gopherbot
Copy link

Change https://golang.org/cl/184164 mentions this issue: runtime: fix pprof cpu profile corruption on arm/mips/mipsle

@golang golang locked and limited conversation to collaborators Jun 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

5 participants