Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/mobile/cmd/gomobile: -prefix doesn't work #24986

Closed
tsavola opened this issue Apr 21, 2018 · 3 comments
Closed

x/mobile/cmd/gomobile: -prefix doesn't work #24986

tsavola opened this issue Apr 21, 2018 · 3 comments
Labels
FrozenDueToAge mobile Android, iOS, and x/mobile NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@tsavola
Copy link
Contributor

tsavola commented Apr 21, 2018

What version of Go are you using (go version)?

go version go1.10.1 darwin/amd64

Does this issue reproduce with the latest release?

Yes, with latest gomobile.

What operating system and processor architecture are you using (go env)?

GOARCH="amd64"
GOBIN="/Users/timo/bin"
GOCACHE="/Users/timo/Library/Caches/go-build"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/timo"
GORACE=""
GOROOT="/usr/local/go"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/cc/h_53mv290h5c8l_y0l3w1fy00000gn/T/go-build114935612=/tmp/go-build -gno-record-gcc-switches -fno-common"

I also have Xcode 9.3 installed.

What did you do?

cd $GOPATH/src/golang.org/x/mobile/example/bind/hello
gomobile bind -target=ios -prefix=My golang.org/x/mobile/example/bind/hello

What did you expect to see?

Hello.framework or MyHello.framework directory (don't know which name it would use - not important).

What did you see instead?

gomobile: open /var/folders/cc/h_53mv290h5c8l_y0l3w1fy00000gn/T/gomobile-work-122259635/src/gobind/MyHello.objc.h: no such file or directory
@gopherbot gopherbot added this to the Unreleased milestone Apr 21, 2018
@gopherbot gopherbot added the mobile Android, iOS, and x/mobile label Apr 21, 2018
maierwdy added a commit to maierwdy/mobile that referenced this issue Apr 27, 2018
@maierwdy
Added missing prefix to generated ObjC filenames.
d2703ff 
golang/go#24986
@maierwdy
Copy link

I found the same issues in the newer gomobile versions and linked a possible solution in my fork.

@AlexRouSg AlexRouSg mentioned this issue Apr 27, 2018
Closed
@bcmills bcmills added the NeedsFix The path to resolution is known, but the work has not been done. label Apr 27, 2018
@bcmills
Copy link
Contributor

bcmills commented Apr 27, 2018

@maierwdy, want to upstream your fix?

@gopherbot
Copy link

Change https://golang.org/cl/110058 mentions this issue: cmd/gobind: fix build of ObjC bindings with a custom prefix

@golang golang locked and limited conversation to collaborators May 1, 2019
imWildCat pushed a commit to imWildCat/go-mobile that referenced this issue Apr 10, 2021
cmd/gobind: fix build of ObjC bindings with a custom prefix
4152cd0 
Also add a test. The corresponding Java custom package option
already have one.

Fixes golang/go#24986

Change-Id: I095d97022beb0a57df784fe0a12bc42a66bb8a07
Reviewed-on: https://go-review.googlesource.com/110058
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
imWildCat pushed a commit to imWildCat/go-mobile that referenced this issue Apr 11, 2021
cmd/gobind: fix build of ObjC bindings with a custom prefix
ce49b7a 
Also add a test. The corresponding Java custom package option
already have one.

Fixes golang/go#24986

Change-Id: I095d97022beb0a57df784fe0a12bc42a66bb8a07
Reviewed-on: https://go-review.googlesource.com/110058
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge mobile Android, iOS, and x/mobile NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@tsavola @bcmills @maierwdy @gopherbot