New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
access: Gerrit Approver Access ("approvers") #24964
Comments
Disclaimer: I don't have experience with @namusyaka's contributions outside of As for How will gaining the approver bit change things, in practice? Code changes (in the Go main repo and under Also, the approval bit generally implies familiarity with the code they're approving for. On the other hand, https://go-review.googlesource.com/c/net/+/94838 is a recent change of yours, which had lots of review comments. I'm not saying that you're a bad programmer. Even good programmers miss some things when modifying unfamiliar code. Not every nuance is captured in the code itself, its nearby comments and the test suite, and sometimes you just need to know what far-away documentation is relevant (or missing!). I'm just saying that you're not yet completely familiar with the subtleties of the Sorry to sound negative. I appreciate the work you're doing in I'll repeat that I'm not familiar with your other work, such as in |
@nigeltao I appreciate your comment. Please let me supplement some.
Currently, the parser of the And I have been doing continuous contributions (probably go 20+ commits + other packages => 40+ commits) from last year on other packages and gardening some issues, but it is hard to say that I am perfectly familiar with I don't know the clear criteria to get the bit (or unexistence?). Thanks. |
See https://golang.org/wiki/GerritAccess
Want: https://go-review.googlesource.com/#/admin/groups/1005,members
My gerrit name: Kunpei Sakai
My gerrit email: namusyaka@gmail.com
All my gardening issues: https://github.com/golang/go/issues?utf8=%E2%9C%93&q=is%3Aissue+commenter%3Anamusyaka+
All my participating CLs: https://go-review.googlesource.com/q/namusyaka%2540gmail.com
At first, @spf13 thank you for showing clear policy at #24850 . I was just thinking about requesting an approver in gerrit for maintenance of the
x/net/html
package. Of course I am going to continue committing about other packages such ascmd/compile
andnet/http
.I have improved the parser implementation of the x/net/html package based on the implementation of chromium (blink) and webkit for a while, but I thought that we need to tackle this in the medium to long term.
If necessary, we will need to develop it while communicating with the chromium team. I'm going to do that.
/cc @andybons @bradfitz @nigeltao
The text was updated successfully, but these errors were encountered: