Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gerritbot: perform gofmt checks before pushing to Gerrit #24946

Open
tklauser opened this issue Apr 19, 2018 · 4 comments
Open

x/build/cmd/gerritbot: perform gofmt checks before pushing to Gerrit #24946

tklauser opened this issue Apr 19, 2018 · 4 comments
Labels
Builders x/build issues (builders, bots, dashboards) help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@tklauser
Copy link
Member

In https://golang.org/cl/99337 a file using CRLF instead of LF line endings was added. When using git-codereview to send CLs, there is a gofmt check which prevents this. But it seems there is no corresponding check when sending CLs via Github PRs.

It would be nice to run the gofmt check also for PRs submitted via Github.

/cc @bradfitz @andybons
@gopherbot gopherbot added this to the Unreleased milestone Apr 19, 2018
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Apr 19, 2018
@andybons andybons added help wanted NeedsFix The path to resolution is known, but the work has not been done. labels Apr 19, 2018
@gopherbot
Copy link

Change https://golang.org/cl/114255 mentions this issue: debug/pe: gofmt

@tklauser
Copy link
Member Author

There was a similar issue with https://golang.org/cl/110555

gopherbot pushed a commit that referenced this issue May 23, 2018
@tklauser
debug/pe: gofmt
4bb649f 
CL 110555 introduced some changes which were not properly gofmt'ed.
Because the CL was sent via Github the gofmt checks usually performed by
git-codereview didn't catch this (see #24946).

Change-Id: I65c1271620690dbeec88b4ce482d158f7d6df45d
Reviewed-on: https://go-review.googlesource.com/114255
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
@andybons andybons changed the title x/build/cmd/gopherbot: perform gofmt checks before pushing to Gerrit x/build/cmd/gerritbot: perform gofmt checks before pushing to Gerrit May 23, 2018
@bradfitz
Copy link
Contributor

I still would rather prioritize #18548

@gopherbot
Copy link

Change https://golang.org/cl/115356 mentions this issue: os/exec: gofmt

gopherbot pushed a commit that referenced this issue May 30, 2018
@tklauser @bradfitz
os/exec: gofmt
7ea2c8c 
CL 109361 introduced some changes which were not properly gofmt'ed.
Because the CL was sent via Github no gofmt checks were performed
on it (cf. #24946, #18548).

Change-Id: I207065f01161044c420e272f4fd112e0a59be259
Reviewed-on: https://go-review.googlesource.com/115356
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@bradfitz @andybons @tklauser @gopherbot