Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gerritbot: don't push to Gerrit if checklist hasn't been deleted #24932

Open
bradfitz opened this issue Apr 18, 2018 · 0 comments
Open

x/build/cmd/gerritbot: don't push to Gerrit if checklist hasn't been deleted #24932

bradfitz opened this issue Apr 18, 2018 · 0 comments
Labels
Builders x/build issues (builders, bots, dashboards)
Milestone
Unreleased

Comments

@bradfitz
Copy link
Contributor

In #24927 the checklist was kept in the commit message and gopherbot pushed it to Gerrit.

Gopherbot could instead just look for "Please ensure you adhere to every item in this list" and, if found, refuse to push it to Gerrit, saying something on the PR instead.

/cc @andybons
@gopherbot gopherbot added this to the Unreleased milestone Apr 18, 2018
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Apr 18, 2018
@andybons andybons self-assigned this Apr 18, 2018
@andybons andybons changed the title x/build/cmd/gopherbot: don't push to Gerrit if checklist hasn't been deleted x/build/cmd/gerritbot: don't push to Gerrit if checklist hasn't been deleted Nov 9, 2018
@andybons andybons removed their assignment Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards)
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bradfitz @andybons @gopherbot