Comment 1:

btw - I could try whip-up a test to check that for sizes of all datatypes.  IIRC, this
is the second error of this kind I've encountered so far.

Comment 2:

The Rlimit struct is provided by
  src/pkg/syscall/ztypes_$GOOS_$GOARCH.go
that is generated with
  cgo -godefs types_linux.go
It's possible that this was done on a 64-bit Linux machine or a machine with the
different headers to yours. I'm not sure how that would have happened. Can you try
regenerating ztypes_linux_386.go on your machine and tell us what the diff is?

Owner changed to @adg.

Status changed to WaitingForReply.

Comment 3:

I'll have a look. I run fedora on this machine though, so the last time I tried, there
were a lot of spurious differences due to the go stuff being run on a ubuntu lucid.

Comment 4:

a bug in cgo?
$   cgo -godefs types_linux.go|grep -C3 Rlimit
    Nivcsw      int32
}
type Rlimit struct {
    Cur uint64
    Max uint64
}
[hanwen@haring syscall]$ uname -a
Linux haring 3.1.1-2.fc16.i686 #1 SMP Mon Nov 14 16:16:34 UTC 2011 i686 i686 i386
GNU/Linux

Comment 5:

there is a rlimit and rlimit64, 
struct rlimit
  {
    rlim_t rlim_cur;
    rlim_t rlim_max;
  };
struct rlimit64
  {
    rlim64_t rlim_cur;
    rlim64_t rlim_max;
 };
with accompanying syscalls, 
extern int getrlimit (__rlimit_resource_t __resource, struct rlimit *__rlimits) __asm__
("" "getrlimit64") __attribute__ ((__nothrow__))
extern int getrlimit64 (__rlimit_resource_t __resource,
   struct rlimit64 *__rlimits) __attribute__ ((__nothrow__));
could it be that cgo matches the 64 bit type to the 32bit call?

Comment 6:

strace on C version:
getrlimit(RLIMIT_NOFILE, {rlim_cur=1024, rlim_max=4*1024}) = 0
strace on Go version:
old_getrlimit(RLIMIT_NOFILE, {rlim_cur=1024, rlim_max=4*1024}) = 0

Comment 8:

and here is the header of types_linux.go expanded with gcc -E

Attachments:

1. expand.c.gz (27923 bytes)

Comment 9:

Labels changed: added priority-later.

Comment 10:

I did some more digging.
The problem is that the Go types_linux.go defines: 
#define _FILE_OFFSET_BITS 64
this causes the source to be compiled with 64 bits rlim_t; the getrlimit() call is then
aliased to prlimit() (strace identifies it as prlimit64).
The correct solution is to implement Go's Getrlimit on Linux in terms of SYS_PRLIMIT64
How does one do that in the source code of the syscall package?

Comment 11:

If it is just a matter of calling a different syscall (no parameters
change), then change
//sysnb Getrlimit(resource int, rlim *Rlimit) (err error)
to
//sysnb Getrlimit(resource int, rlim *Rlimit) (err error) = SYS_PRLIMIT64
and run mkall.sh -syscalls.  If you need to do some kind of conversion
of the arguments, delete that line, add
//sysnb prlimit64(whatever) (err error)
run mkall.sh -syscalls, and then edit syscall_linux.go to define func Getrlimit
in terms of prlimit64.
Russ

Comment 12:

Status changed to Accepted.

Comment 13:

This issue was closed by revision 8b7d39e.

Status changed to Fixed.