Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile/internal/ssa: a wrong arm64 rule #24907

Closed
benshi001 opened this issue Apr 18, 2018 · 1 comment
Closed

cmd/compile/internal/ssa: a wrong arm64 rule #24907

benshi001 opened this issue Apr 18, 2018 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.11

Comments

@benshi001
Copy link
Member

In the file cmd/compile/internal/ssa/gen/ARM64.rules, line 1468 - 1498.

The rule seems to combine 8 load-byte to a single LE load dword. However the final REV is wrong, since it is a LE load.

I will correct it along with my CL touching that part.
@ALTree ALTree added the NeedsFix The path to resolution is known, but the work has not been done. label Apr 18, 2018
@ALTree ALTree added this to the Go1.11 milestone Apr 18, 2018
@gopherbot
Copy link

Change https://golang.org/cl/107376 mentions this issue: cmd/compile: optimize ARM64 with register indexed load/store

@golang golang locked and limited conversation to collaborators Apr 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.11
Development

No branches or pull requests
3 participants
@ALTree @gopherbot @benshi001