Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gopherbot: automatically open backport issues on request #24899

Closed
FiloSottile opened this issue Apr 17, 2018 · 2 comments
Closed

x/build/cmd/gopherbot: automatically open backport issues on request #24899

FiloSottile opened this issue Apr 17, 2018 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@FiloSottile
Copy link
Contributor

GopherBot should learn an invoked command to open the backport issue(s) per https://github.com/golang/go/wiki/MinorReleases.

It should allow the user to specify what versions need the backport in a fairly free syntax (just detect (1\.[\d]+)(\.[\d]+)?) and default to both supported releases.

The whole comment should be quoted as rationale, along with the original title and a link to the original issue.
@gopherbot gopherbot added this to the Unreleased milestone Apr 17, 2018
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Apr 17, 2018
@FiloSottile FiloSottile added the NeedsFix The path to resolution is known, but the work has not been done. label Apr 17, 2018
@dmitshur dmitshur changed the title x/build/gopherbot: automatically open backport issues on request x/build/cmd/gopherbot: automatically open backport issues on request Apr 19, 2018
@gopherbot
Copy link

Change https://golang.org/cl/108298 mentions this issue: cmd/gopherbot: add ability to open backport issues

@gopherbot
Copy link

Change https://golang.org/cl/147437 mentions this issue: cmd/gopherbot: use releases cache for an hour

gopherbot pushed a commit to golang/build that referenced this issue Nov 5, 2018
@dmitshur
cmd/gopherbot: use releases cache for an hour
b7e79bd 
The previous condition could never be true (unless the current time
went back by more than an hour), so the cached releases.major value
was never used. An HTTP request to the remote server was made on each
getMajorReleases call.

This change fixes the condition to use the cached releases.major value
within an hour of fetching it.

Updates golang/go#24899

Change-Id: I71da1b2503075db878b371606436130931dbcc0d
Reviewed-on: https://go-review.googlesource.com/c/147437
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@golang golang locked and limited conversation to collaborators Nov 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@FiloSottile @gopherbot