Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposal: x/crypto/sm3: new package #24898

Closed
FiloSottile opened this issue Apr 17, 2018 · 3 comments
Closed

proposal: x/crypto/sm3: new package #24898

FiloSottile opened this issue Apr 17, 2018 · 3 comments
Labels
FrozenDueToAge Proposal Proposal-Crypto Proposal related to crypto packages or other security issues
Milestone
Proposal

Comments

@FiloSottile
Copy link
Contributor

FiloSottile commented Apr 17, 2018 •
edited by cespare

SM3 is Shang Mi 3, Commercial Cryptographic hash algorithm 3.

https://tools.ietf.org/html/draft-shen-sm3-hash-01

OpenSSL 1.1.1.pre2
https://github.com/openssl/openssl/tree/master/crypto/sm3

armv8.2 has SM3 hardware instructions.
https://community.arm.com/processors/b/blog/posts/introducing-2017s-extensions-to-the-arm-architecture

Linux kernel
https://github.com/torvalds/linux/blob/master/crypto/sm3_generic.c

https://golang.org/cl/106615 by @mengzhuo
@FiloSottile FiloSottile added Proposal Proposal-Crypto Proposal related to crypto packages or other security issues labels Apr 17, 2018
@gopherbot gopherbot added this to the Proposal milestone Apr 17, 2018
@rsc
Copy link
Contributor

rsc commented Apr 20, 2018

It seems like this is not ready for x/crypto yet: (1) it's still a draft, not an RFC, and (2) it doesn't have widespread use. We are not aiming to collect all possible crypto algorithms in x/crypto, only the ones that have widespread use to justify the Go team maintaining it.

Of course, it would be great to have in the broader Go ecosystem and we encourage you to post it in a different place, perhaps in an appropriate location on GitHub.

@rsc rsc closed this as completed Apr 20, 2018
@zaolin
Copy link

zaolin commented Jun 24, 2018 •
edited

That's not true. SM3 is used in current TPM 2.0 devices world wide. It's a chinese hash algorithm which is allowed to use in China. Multiple crypto libraries implement it.

@yeasy
Copy link

yeasy commented Sep 17, 2018

+1 to let golang support more crypto standards including SM and others.

@golang golang locked and limited conversation to collaborators Sep 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge Proposal Proposal-Crypto Proposal related to crypto packages or other security issues
Projects
None yet
Milestone
Proposal
Development

No branches or pull requests
5 participants
@rsc @FiloSottile @yeasy @zaolin @gopherbot