-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/crypto/acme/autocert: clarify usage of (*Manager).GetCertificate #24894
Comments
What's the |
|
I am not clear what is the issue about. Do you want an example to be added for the GetCertificate method ? |
https://godoc.org/golang.org/x/crypto/acme/autocert#Manager.GetCertificate requires a Once I know how to make a |
I don't have much experience about the package, but from the documentation it seems this function serves as a hook for s := &http.Server{
Addr: ":https",
TLSConfig: &tls.Config{GetCertificate: m.GetCertificate},
} |
Is there a bug against grpc about this too? It might be best handled by them. Even if we were to documented some convoluted workaround to make the pieces all fit together, not everybody will read the docs and want to jump through those hoops. It might be best if grpc made some API changes on their side to make this easy. |
Use NewTLS instead of NewServerTLSFromCert. https://godoc.org/google.golang.org/grpc/credentials#NewTLS We can't add examples for how to plug a tls.Config into all possible client libraries, but let us know if you have an idea of how we could have made that more clear. |
Thank you, feel free to paste answer in stackoverflow |
Would be nice to have a example of
cert, err := m.GetCertificate(...)
so the certificates can be used in GRPC. I fail to come up with a solution.https://godoc.org/golang.org/x/crypto/acme/autocert
https://stackoverflow.com/questions/49874945/acme-certificate-for-grpc
SOLUTION:
The text was updated successfully, but these errors were encountered: