You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
wixVersion and friends are defined in cmd/release/releaselet.go which is protected by a // +build ignore file. Running the tests with -tags=ignore also fails:
$ go test -tags=ignore ./cmd/release
../net/http2/client_conn_pool.go:10:2: found packages tls (alert.go) and main (generate_cert.go) in /Users/kevin/go/src/crypto/tls
../../../google.golang.org/grpc/credentials/credentials.go:27:2: found packages x509 (cert_pool.go) and main (root_darwin_arm_gen.go) in /Users/kevin/go/src/crypto/x509
../../../../go/src/go/build/build.go:12:2: found packages doc (comment.go) and main (headscan.go) in /Users/kevin/go/src/go/doc
cmd/release/release.go:30:2: found packages build (build.go) and main (update-readmes.go) in /Users/kevin/src/golang.org/x/build
../text/secure/bidirule/bidirule.go:16:2: found packages bidi (bidi.go) and main (gen.go) in /Users/kevin/src/golang.org/x/text/unicode/bidi
What's the best way forward?
Proceed with a broken test suite (not ideal)
Change the build tag from ignore to something else, then give both releaselet.go and releaselet_test.go the new build tag.
Put the functions under test in a different file with a different build flag, then edit the build scripts to upload/run both releaselet.go and the new file.
Delete the tests.
Give the tests the ignore build tag and basically never run them.
Some other solution I'm not thinking of.
Thoughts?
The text was updated successfully, but these errors were encountered:
Running "go test golang.org/x/build/cmd/release" currently fails with the following error:
wixVersion
and friends are defined in cmd/release/releaselet.go which is protected by a// +build ignore
file. Running the tests with-tags=ignore
also fails:What's the best way forward?
ignore
to something else, then give both releaselet.go and releaselet_test.go the new build tag.ignore
build tag and basically never run them.Thoughts?
The text was updated successfully, but these errors were encountered: