Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc/contribute.html: clarify commit-message conventions #24852

Closed
bcmills opened this issue Apr 13, 2018 · 6 comments
Closed

doc/contribute.html: clarify commit-message conventions #24852

bcmills opened this issue Apr 13, 2018 · 6 comments

Comments

@bcmills
Copy link
Contributor

bcmills commented Apr 13, 2018

#24832 proposes that we auto-wrap commit messages when importing from GitHub.

It would probably also be a good idea to document our wrapping conventions: I don't currently see that detail on https://golang.org/doc/contribute.html#commit_changes, although the whole page is a bit difficult to skim as a reference anyway.

I initially had some difficulty with the package-prefix convention too: more examples would probably be helpful there. For example, it's not obvious what to do with the x/ repos, or packages with nested paths, or things that are not importable Go packages.

(One can discover those conventions by reading the change history, but that seems like a high bar for a first-time contributor who may well just be fixing a typo in a doc comment.)

@bcmills bcmills added this to the Unreleased milestone Apr 13, 2018
@myitcv
Copy link
Member

myitcv commented Apr 13, 2018

#24832 proposes that we auto-wrap commit messages when importing from Gerrit.

... from Github. At least that was my intention...

@bcmills
Copy link
Contributor Author

bcmills commented Apr 13, 2018

Yep, I thinko'd it.

@mbj36
Copy link
Contributor

mbj36 commented Apr 15, 2018

@bcmills

I am interested in taking up this issue, Am i missing something because i see https://github.com/golang/go/blob/master/doc/contribute.html is bit different from https://golang.org/doc/contribute.html ?

@agnivade
Copy link
Contributor

The golang.org site does not reflect master. Try https://tip.golang.org/doc/contribute.html.

@mbj36
Copy link
Contributor

mbj36 commented Apr 15, 2018

@agnivade How can i run the doc locally ?

@gopherbot
Copy link

Change https://golang.org/cl/107197 mentions this issue: doc: improve commit messages

@golang golang locked and limited conversation to collaborators Apr 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants