Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/crypto/openpgp: Encrypt() is missing the compression part #24847

Closed
gprggr opened this issue Apr 13, 2018 · 3 comments
Closed

x/crypto/openpgp: Encrypt() is missing the compression part #24847

gprggr opened this issue Apr 13, 2018 · 3 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@gprggr
Copy link

gprggr commented Apr 13, 2018

What version of Go are you using (go version)?

go 1.10.1

openpgp.Encrypt(...) is missing the compression part. I fixed it for me by taking a piece of code from
openpgp.SymmetricallyEncrypt(...) beginning at line 123.

diff write.go.old write.go
write.go.diff.txt
@gopherbot gopherbot added this to the Unreleased milestone Apr 13, 2018
@agnivade agnivade added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 13, 2018
@agnivade
Copy link
Contributor

/cc @FiloSottile @agl

@byxiangfei
Copy link

found this issue, too. Go version 1.12

@FiloSottile
Copy link
Contributor

Per the accepted #44226 proposal and due to lack of maintenance, the golang.org/x/crypto/openpgp package is now frozen and deprecated. No new changes will be accepted except for security fixes. The package will not be removed.

If this is a security issue, please email security@golang.org and we will assess it and provide a fix.

If you're looking for alternatives, consider the crypto/ed25519 package for simple signatures, golang.org/x/mod/sumdb/note for inline signatures, or filippo.io/age for encryption. You can read a summary of OpenPGP issues and alternatives here.

If you are required to interoperate with OpenPGP systems and need a maintained package, we suggest considering one of multiple community forks of golang.org/x/crypto/openpgp. We don't endorse any specific one.

@golang golang locked and limited conversation to collaborators Mar 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@FiloSottile @agnivade @byxiangfei @gopherbot @gprggr