Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gopherbot: don't fight humans #24834

Closed
FiloSottile opened this issue Apr 12, 2018 · 5 comments
Closed

x/build/cmd/gopherbot: don't fight humans #24834

FiloSottile opened this issue Apr 12, 2018 · 5 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@FiloSottile
Copy link
Contributor

Gopherbot is supposed not to fight humans, but it happened in at least these two occasions recently:
@gopherbot gopherbot added this to the Unreleased milestone Apr 12, 2018
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Apr 12, 2018
@FiloSottile
Copy link
Contributor Author

See also #21312

@FiloSottile FiloSottile added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 12, 2018
@mvdan
Copy link
Member

mvdan commented Apr 12, 2018

Maybe it needs to be taught the three laws of robotics.

@bradfitz
Copy link
Contributor

The WaitingForInfo bot waits for the OP to reply. So it looks like #24321 was working as designed, at least. Maybe the design is wrong.

I suppose #24597 could be fixed to permit non-Builder bugs with prefix x/build, but I don't see the point. Really, the "Builder" label means "things in the x/build repo", so I think it's fine as-is. But I'd prefer we just do #23223.

The #21312 documentation label one is a bug, though.

@bcmills
Copy link
Contributor

bcmills commented Apr 13, 2018 •
edited

For the WaitingForInfo case, perhaps we should consider any comment accompanied by a reopening to be “more info”: we should only re-close the issue if it was reopened without comment.

@dmitshur dmitshur changed the title x/build/gopherbot: don't fight humans x/build/cmd/gopherbot: don't fight humans Apr 19, 2018
@dmitshur
Copy link
Contributor

I'm going to fold this issue into #21312, since it's the same thing. I'll take its title since it's easer to find and more accurate.

@josharian josharian mentioned this issue Oct 15, 2018
Open
@golang golang locked and limited conversation to collaborators Oct 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
6 participants
@bradfitz @FiloSottile @dmitshur @mvdan @bcmills @gopherbot