exp/inotify: Read hangs, AddWatch, RemoveWatch fail on recreated directories #2483
Labels
Milestone
Comments
Fix up for review at: http://golang.org/cl/5418045/ |
simple 5 line fix that removes the watch whenever inotify removes the watch (sends the IN_IGNORED event). http://golang.org/cl/6553059/ |
Ken-ichirou MATSUAWA opened a pull request for this issue in fsnotify. https://github.com/go-fsnotify/fsnotify/pull/39 |
|
fsnotify has been removed from exp |
mpolden
added a commit
to mpolden/unp
that referenced
this issue
Jul 21, 2015
Replace the deprecated golang.org/x/exp/inotify dependency with github.com/rjeczalik/notify. This solves the issue with rewatching of deleted directories: golang/go#2483, which was never fixed in exp. The notify package also provides recursive watching which replaces the existing custom code.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Before filing a bug, please check whether it has been fixed since the latest release: run "hg pull", "hg update default", rebuild, and retry what you did to reproduce the problem. Thanks. What steps will reproduce the problem? - If I am watching a directory, and delete it, and recreate it, and watch it again, any events after that are hosed: - the event.Name is incomplete, with the path stripped out e.g. instead of /home/myname/a/b/c/d.txt, I get /d.txt instead of /home/myname/a/b/c/, I get "" - RemoveWatch fails with message: invalid argument - Close() doesn't really close. Most times, the reader goroutine hangs. Which compiler are you using (5g, 6g, 8g, gccgo)? 8g Which operating system are you using? Ubuntu Linux 2.6.38-12-generic #51-Ubuntu SMP 32-bit GNU/Linux Which revision are you using? (hg identify) 6abf04c86097+ tip Please provide any additional information below.The text was updated successfully, but these errors were encountered: