Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/cmd/guru: failing tests for Go 1.9 and Go 1.10 #24798

Closed
bradfitz opened this issue Apr 10, 2018 · 1 comment
Closed

x/tools/cmd/guru: failing tests for Go 1.9 and Go 1.10 #24798

bradfitz opened this issue Apr 10, 2018 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.11

Comments

@bradfitz
Copy link
Contributor

The x/tools subrepo is broken for Go 1.9 and Go 1.10 because of cmd/guru.

See the red at https://build.golang.org/ for examples.

testdata/src/softerrs/main.go:8:6: i declared but not used
--- FAIL: TestGuru (86.23s)
	guru_test.go:293: Guru tests for testdata/src/referrers/main.go failed: exit status 1.
		--- testdata/src/referrers/main.golden	2018-04-10 16:42:09.000000000 +0000
		+++ testdata/src/referrers/main.got	2018-04-10 17:15:33.512638000 +0000
		@@ -56,5 +56,5 @@
		 
		 -------- @referrers ref-type-U --------
		 references to type U int
		-open nosuchfile.y: no such file or directory (+ 1 more refs in this file)
		+open testdata/src/referrers/nosuchfile.y: no such file or directory (+ 1 more refs in this file)
		 
		
FAIL
FAIL	golang.org/x/tools/cmd/guru	86.372s
@bradfitz bradfitz added the NeedsFix The path to resolution is known, but the work has not been done. label Apr 10, 2018
@bradfitz bradfitz added this to the Go1.11 milestone Apr 10, 2018
@bradfitz
Copy link
Contributor Author

Duplicate of #24421

@bradfitz bradfitz marked this as a duplicate of #24421 Apr 11, 2018
@golang golang locked and limited conversation to collaborators Apr 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.11
Development

No branches or pull requests
3 participants
@bradfitz @alandonovan @gopherbot