Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gopherbot: support abandoning CLs #24792

Closed
mvdan opened this issue Apr 10, 2018 · 2 comments
Closed

x/build/cmd/gopherbot: support abandoning CLs #24792

mvdan opened this issue Apr 10, 2018 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Milestone
Unreleased

Comments

@mvdan
Copy link
Member

mvdan commented Apr 10, 2018

For example, if one opens a pull request but does not have a Gerrit account, the CL will be owned by the bot and thus not modifiable by the user directly.

It would be useful if the bot could mirror the PR being closed to Gerrit - that is, abandoning the CL. Just saw this happening with https://go-review.googlesource.com/c/go/+/102476, where the proposal was rejected and the PR closed, but OP does not have access to the CL directly. In this case, I'll abandon the CL myself manually.
@gopherbot gopherbot added this to the Unreleased milestone Apr 10, 2018
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Apr 10, 2018
@agnivade
Copy link
Contributor

I was going to file an issue. But seems like it already exists #23850.

@mvdan
Copy link
Member Author

mvdan commented Apr 10, 2018

You're absolutely right; I spent a couple of minutes trying to find it, but failed to.

@mvdan mvdan closed this as completed Apr 10, 2018
@golang golang locked and limited conversation to collaborators Apr 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@agnivade @mvdan @gopherbot