Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/maintner: two Gerrit CLs have unexpected Status value #24783

Closed
dmitshur opened this issue Apr 9, 2018 · 6 comments
Closed

x/build/maintner: two Gerrit CLs have unexpected Status value #24783

dmitshur opened this issue Apr 9, 2018 · 6 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Apr 9, 2018

maintner.GerritCL.Status is documented as:

// Status will be "merged", "abandoned", "new", or "draft".
Status string

That's mostly true, except for 2 CLs in the go repo:

2018/04/05 21:51:56 empty status for CL 44073
2018/04/05 21:51:56 empty status for CL 44072

Those 2 CLs have empty string value in Status field.

Either the documentation needs to be updated, or this is bug and those 2 CLs shouldn't have empty status.
@dmitshur dmitshur added Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Apr 9, 2018
@gopherbot gopherbot added this to the Unreleased milestone Apr 9, 2018
@andybons
Copy link
Member

andybons commented Apr 9, 2018

/cc @bradfitz

@bradfitz
Copy link
Contributor

bradfitz commented Apr 9, 2018

Anything interesting about those CLs?

@FiloSottile
Copy link
Contributor

They both 404 for me.

@andybons
Copy link
Member

andybons commented Apr 9, 2018

Both are 404’s, which means it’s likely that the CLs were deleted. We don’t account for deleted changes: #22635.

@billotosyr
Copy link

Previously mentioned: #22060

@dmitshur
Copy link
Contributor Author

I'll close this as duplicate of #22060.

@golang golang locked and limited conversation to collaborators Apr 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
6 participants
@bradfitz @andybons @FiloSottile @dmitshur @gopherbot @billotosyr