Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types2: type-check syntax nodes directly (don't use types2 maps) #24780

Open
griesemer opened this issue Apr 9, 2018 · 8 comments
Open

types2: type-check syntax nodes directly (don't use types2 maps) #24780

griesemer opened this issue Apr 9, 2018 · 8 comments
Assignees
@griesemer
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Backlog

Comments

@griesemer
Copy link
Contributor

griesemer commented Apr 9, 2018 •
edited
Loading

[edit: By setting type information directly in syntax nodes rather than storing in types2 maps, we should be able to recover some of the compiler speed loss of Go 1.18.]

We should move type-checking to operate directly on the new syntax nodes. Placeholder issue.

Set for Go1.12 so it stays on the radar. Unclear yet if that is a realistic goal.
@griesemer griesemer added this to the Go1.12 milestone Apr 9, 2018
@griesemer griesemer self-assigned this Apr 9, 2018
@griesemer griesemer mentioned this issue Apr 9, 2018
Open
@rasky
Copy link
Member

rasky commented Apr 9, 2018

Is this something where new contributors can help? Is it sort of a long-term incremental task where you can lead by example with a few CLs and then people can follow the lead and submit more?

@griesemer
Copy link
Contributor Author

@rasky Sorry, this is definitively not a task for new contributors. If we're going to do this we need to do this in the Go Team, with dedicated engineering. Thanks.

@griesemer griesemer modified the milestones: Go1.12, Go1.13 Oct 24, 2018
@griesemer
Copy link
Contributor Author

Moving to 1.13.

@griesemer griesemer modified the milestones: Go1.13, Go1.14 May 6, 2019
@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
@griesemer griesemer changed the title cmd/compile: type-check cmd/compile/internal/syntax nodes directly types2: type-check syntax nodes directly (don't use types2 maps) Mar 18, 2022
@griesemer griesemer modified the milestones: Backlog, Go1.19 Mar 18, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/396917 mentions this issue: cmd/compile: store type information directly in syntax tree

@griesemer griesemer modified the milestones: Go1.19, Go1.20 May 11, 2022
@griesemer
Copy link
Contributor Author

Some progress has been made on this: syntax expression nodes now can be augmented directly.

@griesemer griesemer modified the milestones: Go1.20, Go1.21 Nov 15, 2022
@griesemer
Copy link
Contributor Author

Moving to 1.22.

@griesemer griesemer modified the milestones: Go1.21, Go1.22 May 25, 2023
@griesemer
Copy link
Contributor Author

Moving to 1.23.

@griesemer griesemer modified the milestones: Go1.22, Go1.23 Oct 31, 2023
@griesemer
Copy link
Contributor Author

Not a high-priority issue at the moment. Moving to backlog.

@griesemer griesemer modified the milestones: Go1.23, Backlog Feb 7, 2024
@seankhliao seankhliao added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@griesemer griesemer

Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
6 participants
@rsc @rasky @ianlancetaylor @griesemer @gopherbot @seankhliao