New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/vgo: VGOROOT is not a Go 1.10 source tree #24773
Comments
I'm not familiar with |
Thanks. I installed go from sources and when I hit the same command
I believe this is the correct message. Should I make a bug report to the package maintainer? |
grr, I did not save that comment yet (github, sorry y'all)... this is an issue with https://github.com/golang/vgo/blob/master/vendor/cmd/go/internal/cfg/cfg.go#L126 basically arch and other distros don't include the file that is being checked for to confirm the go version: https://www.archlinux.org/packages/extra/x86_64/go/ (this is also an issue with debian, saw a conversation about it the other day but can't find it now)... It would be nice if we could find a way to resolve this that didn't require all distros change their package method OR everyone install from source. a quick and dirty fix (just tested in arch) sudo mkdir /usr/lib/go/api
sudo touch /usr/lib/go/api/go1.10.txt |
Since When/if it gets merged back into the |
Thank you for all the informations. I let you close it if you want to. |
Did you report this upstream to Arch? |
As @bcmills pointed, For me, at this point if you really want to use or try |
Yes but why doen't Arch include these files? Does everyone that want to try vgo install from source? The installers from golang.org works right? Why mess with them? This is so like Arch, I have run it for ages but there is always stuff like this from time to time that is totally not needed.... |
@dahankzter this isn't specific to Arch, go run Debian and the exact same thing will occur... The files that vgo is looking for that these distros are leaving out are only needed for tests usually, the requirement that vgo be able to find that file is a change in the actual install requirements (IE: now those files are needed for more than just tests); you can hardly blame the Arch (or debian) maintainers for not foreseeing that test files would be needed in the real world suddenly when they weren't before. |
Needed for tests usually is the operating word I think. Why do this at all?
It only makes it fragile and prone to breakage to modify stuff like this
which was to be proven by this very issue.
Again this is why people get tired of package managers and downstream
"tweaks"...
Don't get me wrong, Arch is usually doing a great packaging job and it
works very well given the pace of updates but it has been a mess sometimes
such as the whole Haskell explosion that at least used to happen from time
to time.
This didn't have to happen and it can be fixed but upstream needs to know
for that to occur.
…On Mon, Apr 16, 2018, 17:14 Nathan Bass ***@***.***> wrote:
@dahankzter <https://github.com/dahankzter> this isn't specific to Arch,
go run Debian and the exact same thing will occur... The files that vgo is
looking for that these distros are leaving out are only needed for tests
usually, the requirement that vgo be able to find that file is a change in
the actual install requirements (IE: now those files are needed for more
than just tests); you can hardly blame the Arch (or debian) maintainers for
not foreseeing that test files would be needed in the real world suddenly
when they weren't before.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#24773 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAKcU8ZdPhnd9m-0k4WjIxSS245d3T5tks5tpLU8gaJpZM4TMUkF>
.
|
Here is the line that causes |
@alexandrestein can you explain this "true reason"? It'll need to be addressed eventually. |
I can't. 😄 I actually switched to installation from source and I did not made any further investigations since. But apparently @klingtnet did and found that the issue was caused by a missing file. |
Right, the missing file is easy enough to fix. vgo should probably use |
I don't think it does require the source tree, I've been using it on arch without a full source tree (just the above fix) without issues; unless someone can confirm that something else in the source tree is required I believe the only refactoring should really be implementing the version check as @SirCmpwn described. |
Can confirm this. |
Same for me after I have copied the |
Happened to me on Xubuntu 16.04.4, @IngCr3at1on fix solved my problem. |
What version of Go are you using (
go version
)?go version go1.10.1 linux/amd64
onArch
installed withpacman
.Does this issue reproduce with the latest release?
I only with tried this version.
What operating system and processor architecture are you using (
go env
)?Arch Linux
64bit (up-to-date)What did you do?
I installed
vgo
withgo get -u golang.org/x/vgo
.I run
vgo -h
What did you expect to see?
I was expecting some help from the command.
What did you see instead?
I have a error message which I don't really understand:
vgo requires Go 1.10 but VGOROOT=/usr/lib/go is not a Go 1.10 source tree
No matter, from where I try to run the command or if I set the
VGOROOT
to a directory inside theGo tree
.The text was updated successfully, but these errors were encountered: