-
Notifications
You must be signed in to change notification settings - Fork 18k
internal/cpu: cpu feature detect failed on darwin/arm64 #24753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@eliasnaur I've open an issue here. Since I don't know how to build up a darwin/arm64 platform on my Mac maybe you can give me some page/ tutorial about it. |
Apparently the implementation in internal/cpu/cpu_arm64.go is Linux only. On darwin, arm64_hwcap is not linknamed from runtime/os_darwin_arm64.go, and it doesn't have the same hwcap anyway. So internal/cpu doesn't work on darwin/arm64. |
It's some work to set up, so if you like, I can test any CL that you come up with. If you like to attempt a darwin/arm64 setup, the steps are roughly:
Because of the way they're harnessed, running tests are quite slow on iOS. You may want to run only your test with |
@eliasnaur I think I will add a CL that remove darwin/openbsd support right now to let them pass the test. And add another CL to support darwin/netbsd etc. |
Change https://golang.org/cl/105455 mentions this issue: |
What version of Go are you using (
go version
)?go 1.10 and tip
What did you do?
run ./all.bash
What did you expect to see?
all test pass
The text was updated successfully, but these errors were encountered: