Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/vgo: include GOPROXY in output of vgo env #24748

Closed
myitcv opened this issue Apr 7, 2018 · 5 comments
Closed

x/vgo: include GOPROXY in output of vgo env #24748

myitcv opened this issue Apr 7, 2018 · 5 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@myitcv
Copy link
Member

myitcv commented Apr 7, 2018

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

go version go1.10.1 linux/amd64 vgo:2018-02-20.1

Specifically vgo is as of 5db81b5cd6ab5ee1dd1b1b0ee0843f194ab7b908

Does this issue reproduce with the latest release?

Yes.

What operating system and processor architecture are you using (go env)?

GOARCH="amd64"
GOBIN=""
GOCACHE="/home/myitcv/.cache/go-build"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/myitcv/.mountpoints/x"
GORACE=""
GOROOT="/home/myitcv/gos"
GOTMPDIR=""
GOTOOLDIR="/home/myitcv/gos/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build749051986=/tmp/go-build -gno-record-gcc-switches"
VGOMODROOT=""

What did you do?

vgo env | grep GOPROXY

What did you expect to see?

GOPROXY=""

(or whatever value is present in that environment variable)

What did you see instead?

Nothing; GOPROXY is not included in the env output.

@vbmade2000
Copy link

Can I wok on this issue ?

@rsc
Copy link
Contributor

rsc commented Apr 9, 2018

SGTM.

@rsc rsc added the NeedsFix The path to resolution is known, but the work has not been done. label Apr 9, 2018
@myitcv
Copy link
Member Author

myitcv commented Apr 9, 2018

This has been started in https://go-review.googlesource.com/c/vgo/+/105335

@vbmade2000
Copy link

@myitcv Ok

@gopherbot
Copy link

Change https://golang.org/cl/105335 mentions this issue: x/vgo: include GOPROXY in env output

@golang golang locked and limited conversation to collaborators Apr 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

4 participants