Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: emit info about used types in local types section of export data, for checking by ld. #2474

Closed
rsc opened this issue Nov 16, 2011 · 14 comments
Closed

cmd/compile: emit info about used types in local types section of export data, for checking by ld. #2474

rsc opened this issue Nov 16, 2011 · 14 comments
Milestone
Unplanned

Comments

@rsc
Copy link
Contributor

rsc commented Nov 16, 2011 

r:
i put in a print statement and then gotest wouldn't compile the program, which was
correct behavior: a function had changed signature
so before i touched the file gotest was somehow linking incorrectly. i can't explain it
and that's what was wrong

me:
there is one case where that can still happen
if you have an exported struct in one package and another package emits references to
fields in that struct, but it doesn't also emit a copy of that struct in its own export
data, then the linker can't tell if it saw the same definition as the other package
i have been meaning to emit as part of the read-only-by-the-linker export data 'these
are the struct definitions i used while generating code'
@rsc
Copy link
Contributor Author

rsc commented Nov 18, 2011

Comment 1:

Same goes for functions called: their signatures might change.

@rsc
Copy link
Contributor Author

rsc commented Dec 9, 2011

Comment 2:

Labels changed: added priority-later, removed priority-medium.

@rsc
Copy link
Contributor Author

rsc commented Dec 12, 2011

Comment 3:

Labels changed: added priority-go1.

@robpike
Copy link
Contributor

robpike commented Jan 13, 2012

Comment 4:

Owner changed to builder@golang.org.

@rsc
Copy link
Contributor Author

rsc commented Feb 11, 2012

Comment 6:

Now that we have the go tool, this is lower priority.

Labels changed: added priority-later, removed priority-go1.

@rsc
Copy link
Contributor Author

rsc commented Sep 12, 2012

Comment 7:

Labels changed: added go1.1maybe.

@robpike
Copy link
Contributor

robpike commented Mar 7, 2013

Comment 8:

Labels changed: removed go1.1maybe.

@rsc
Copy link
Contributor Author

rsc commented Mar 12, 2013

Comment 9:

[The time for maybe has passed.]

@rsc
Copy link
Contributor Author

rsc commented Jul 30, 2013

Comment 10:

Labels changed: added go1.3.

@robpike
Copy link
Contributor

robpike commented Aug 20, 2013

Comment 11:

Labels changed: removed go1.3.

@rsc
Copy link
Contributor Author

rsc commented Nov 27, 2013

Comment 12:

Labels changed: added go1.3maybe.

@rsc
Copy link
Contributor Author

rsc commented Dec 4, 2013

Comment 13:

Labels changed: added release-none, removed go1.3maybe.

@rsc
Copy link
Contributor Author

rsc commented Dec 4, 2013

Comment 14:

Labels changed: added repo-main.

@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@rsc rsc changed the title cmd/gc: emit info about used types in local types section of export data, for checking by ld. cmd/compile: emit info about used types in local types section of export data, for checking by ld. Jun 8, 2015
@thanm
Copy link
Contributor

thanm commented Dec 21, 2023

Pretty sure this bug is obsolete, closing it out.

@thanm thanm closed this as completed Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
3 participants
@rsc @robpike @thanm