Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

question about syscall and the locked state for contributions #24707

Closed
neolit123 opened this issue Apr 5, 2018 · 2 comments
Closed

question about syscall and the locked state for contributions #24707

neolit123 opened this issue Apr 5, 2018 · 2 comments

Comments

@neolit123
Copy link
Contributor

What version of Go are you using (go version)?

latest master

Does this issue reproduce with the latest release?

yes

What operating system and processor architecture are you using (go env)?

windows XP, 7, 10.
Intel i3, i7

What did you do?

What did you expect to see?

What did you see instead?

hello,
i spoke to @alexbrainman about this and he explained to me that the syscall package is locked for contributions and if i want to contribute missing features for a platform these would not be accepted - e.g. take a look at these calls for Windows:
https://github.com/golang/go/blob/master/src/syscall/syscall_windows.go#L987

would the syscall package enter a unlocked state at some point and what is the golang project mechanic for dealing with such missing features?

the idea behind my question is that i could eventually contribute some of the missing Windows features.

previous contributions:
https://github.com/golang/go/commits?author=neolit123

thanks
lubomir (vmware)

@rsc
Copy link
Contributor

rsc commented Apr 5, 2018

The syscall package in the standard library is only for routines needed by the standard library itself. Other "completeness" additions belong in golang.org/x/sys instead.

@rsc rsc closed this as completed Apr 5, 2018
@neolit123
Copy link
Contributor Author

neolit123 commented Apr 5, 2018

@rsc
thanks for the response,

so i guess if i want to contribute for instance the Chown() family of functions i would need to submit it against this repository?:
https://github.com/golang/sys/blob/master/windows/syscall_windows.go#L1090

@golang golang locked and limited conversation to collaborators Apr 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants