x/tools/cmd/present: notes mode causes different presentations in separate tabs/windows to advance in step #24688
Labels
FrozenDueToAge
help wanted
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
Yes, per above
What operating system and processor architecture are you using (
go env
)?What did you do?
Open the following two presentations in Chrome in two separate tabs in the same window (could be any two presentations, these are just current examples):
https://talks.godoc.org/github.com/stmuk/go-unicode-examples/unicode.slide
https://talks.godoc.org/github.com/mvdan/talks/2018/benchstat.slide
Observe that both start on slide number 1.
Now click to advance the Unicode presentation forward by one slide.
What did you expect to see?
Only the Unicode presentation should advance.
What did you see instead?
If you switch to the tab with the Benchstat presentation you will notice that has also advanced to slide number 2.
This appears to happen because:
localStorage
is usedwindow.location.pathname
in their keySeemingly this behaviour is necessary for notes mode where the notes window and the main deck should advance pari passu (and talks.godoc.org operates in notes mode)
But where there are two different presentations (this issue came up at the London Gophers meetup) then this is less than desirable.
Could the path (
window.location.pathname
) be used to distinguish the keys?As a postscript, if you try to advance the Benchstat presentation beyond slide 13 you will likely find that Chrome's CPU usage jumps because it gets into something of a loop. This appears to be because the Unicode presentation does not have 14 slides and so some loop is triggered.
The text was updated successfully, but these errors were encountered: