cmd/compile: document emitptrargsmap onebitwalktype1 calls #24648
Labels
compiler/runtime
Issues related to the Go compiler and/or runtime.
Documentation
NeedsFix
The path to resolution is known, but the work has not been done.
Milestone
Perhaps I'm missing something, but this sequence of calls in emitptrargsmap looks suspect:
If I'm reading it correctly, this will overwrite the Recvs bitmap with the Params bitmap.
Also, after emitting that bitmap, we do:
But we don't clear bv first, so any set bits from recvs/params will still be set.
emitptrargsmap is only called from assembly functions, which are unlikely to have methods and which are often nosplit, which is possibly why this hasn't caused visible problems yet (?).
cc @mdempsky -- does this code look right to you, and if so, what am I missing?
The text was updated successfully, but these errors were encountered: