Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gerritbot: PR not closed when CL submitted #24618

Closed
FiloSottile opened this issue Mar 31, 2018 · 4 comments
Closed

x/build/cmd/gerritbot: PR not closed when CL submitted #24618

FiloSottile opened this issue Mar 31, 2018 · 4 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@FiloSottile
Copy link
Contributor

Something went wrong with #24613, the CL was submitted but the PR wasn't closed.
@FiloSottile FiloSottile added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 31, 2018
@gopherbot gopherbot added this to the Unreleased milestone Mar 31, 2018
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Mar 31, 2018
@agnivade
Copy link
Contributor

agnivade commented Apr 4, 2018

Another one - #24664

@andybons
Copy link
Member

And another (thanks, @josharian): #25559

It's erroring out because it thinks it has zero commits:

2018/05/26 22:14:02 Retrieving PR golang/go#25559 from GitHub without an Etag ...
2018/05/26 22:14:03 GitHub: 4774/5000 calls remaining; Reset in 14m27.869573024s
2018/05/26 22:14:03 Processing PR https://github.com/golang/go/pull/25559 ...
2018/05/26 22:14:03 corpus.GitHub().ForeachRepo(...): pr has 0 commits

@andybons
Copy link
Member

Ah this is because the original forked repository is gone (user has deleted it). Same for previous instance as well. The one Filippo reported still has it's fork intact, though...

@gopherbot
Copy link

Change https://golang.org/cl/114835 mentions this issue: cmd/gerritbot: don’t abort when PR has zero commits

@golang golang locked and limited conversation to collaborators May 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@andybons @FiloSottile @agnivade @gopherbot