Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/crypto/ssh: TestMuxReadWrite flake #24612

Closed
bradfitz opened this issue Mar 30, 2018 · 1 comment
Closed

x/crypto/ssh: TestMuxReadWrite flake #24612

bradfitz opened this issue Mar 30, 2018 · 1 comment
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Unreleased

Comments

@bradfitz
Copy link
Contributor

Flake on trybot run at https://storage.googleapis.com/go-build-log/4468b0ba/windows-386-2008_b5f0b931.log ...

panic: Fail in goroutine after TestMuxReadWrite has completed

goroutine 1387 [running]:
testing.(*common).Fail(0x12841200)
	C:/workdir/go/src/testing/testing.go:512 +0xf8
testing.(*common).FailNow(0x12841200)
	C:/workdir/go/src/testing/testing.go:534 +0x21
testing.(*common).Fatalf(0x12841200, 0x6ce724, 0x9, 0x12cf5fbc, 0x1, 0x1)
	C:/workdir/go/src/testing/testing.go:600 +0x69
golang.org/x/crypto/ssh.TestMuxReadWrite.func1(0x12a7a400, 0x6cf433, 0xb, 0x12841200, 0x6cfa12, 0xc)
	C:/workdir/gopath/src/golang.org/x/crypto/ssh/mux_test.go:113 +0x1e8
created by golang.org/x/crypto/ssh.TestMuxReadWrite
	C:/workdir/gopath/src/golang.org/x/crypto/ssh/mux_test.go:102 +0x102
FAIL	golang.org/x/crypto/ssh	3.991s

/cc @hanwen
@bradfitz bradfitz added Testing An issue that has been verified to require only test changes, not just a test failure. help wanted NeedsFix The path to resolution is known, but the work has not been done. labels Mar 30, 2018
@gopherbot gopherbot added this to the Unreleased milestone Mar 30, 2018
@hanwen
Copy link
Contributor

hanwen commented Apr 4, 2018

fixed by golang/crypto@b2aa354

@hanwen hanwen closed this as completed Apr 4, 2018
@golang golang locked and limited conversation to collaborators Apr 4, 2019
@rsc rsc unassigned hanwen Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bradfitz @hanwen @gopherbot