Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/releasebot: does not build on HEAD #24598

Closed
h8liu opened this issue Mar 29, 2018 · 4 comments
Closed

x/build/cmd/releasebot: does not build on HEAD #24598

h8liu opened this issue Mar 29, 2018 · 4 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@h8liu
Copy link

h8liu commented Mar 29, 2018

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

go 1.10

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

Does not matter.

What did you do?

go get -u golang.org/x/build/cmd/releasebot

If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.

What did you expect to see?

Build succeeds

What did you see instead?

Build fails
@gopherbot gopherbot added this to the Unreleased milestone Mar 29, 2018
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Mar 29, 2018
@h8liu
Copy link
Author

h8liu commented Mar 29, 2018

GitHub changed there API from using int to int64, and breaks everything that uses that API.

This is found by smallrepo.com, at https://smallrepo.com/builds/20180329-172031-7b4b496e

@h8liu h8liu changed the title x/build/cmd/releasebot does not build on HEAD x/build/cmd/releasebot: does not build on HEAD Mar 29, 2018
@gopherbot
Copy link

Change https://golang.org/cl/103475 mentions this issue: cmd/releasebot: fix usage of GitHub client EditComment

@andybons andybons added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 29, 2018
@dmitshur dmitshur self-assigned this Mar 29, 2018
@dmitshur
Copy link
Contributor

I have a fix. The updateGithubComment implementation was not correct (it was using the wrong ID when editing a comment); this breaking change helped spot that. Sending a CL soon.

@gopherbot
Copy link

Change https://golang.org/cl/103398 mentions this issue: cmd/releasebot: use comment ID in updateGithubComment

@dmitshur dmitshur removed their assignment Mar 29, 2018
gopherbot pushed a commit to golang/build that referenced this issue Mar 30, 2018
@dmitshur
cmd/releasebot: use comment ID in updateGithubComment
35ebb6b 
When editing a comment, the current code used the issue number in place
of the comment ID. But the EditComment endpoint needs the comment ID.

The issue number is not needed at all in updateGithubComment because the
EditComment endpoint uses the repository and comment ID to uniquely
identify the comment.

References:

-	https://developer.github.com/v3/issues/comments/#edit-a-comment.
-	https://godoc.org/github.com/google/go-github/github#IssuesService.EditComment.

Updates golang/go#24598.
Updates google/go-github#883.
Updates google/go-github#597.

Change-Id: Iae9d967d7be7a75b1bcee7118a3c80fe8f2375b4
Reviewed-on: https://go-review.googlesource.com/103398
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@golang golang locked and limited conversation to collaborators Mar 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@andybons @h8liu @dmitshur @gopherbot