Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/sys/windows/svc: servicemain argv pointer truncated #24575

Closed
zhangyoufu opened this issue Mar 28, 2018 · 9 comments
Closed

x/sys/windows/svc: servicemain argv pointer truncated #24575

zhangyoufu opened this issue Mar 28, 2018 · 9 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Windows
Milestone
Unreleased

Comments

@zhangyoufu
Copy link
Contributor

What version of Go are you using (go version)?

1.10

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

Windows x64

What did you do?

review the code

What did you expect to see?

// func servicemain(argc uint32, argv **uint16)
TEXT ·servicemain(SB),7,$0
	MOVL	CX, ·sArgc(SB)
	MOVQ	DX, ·sArgv(SB)

What did you see instead?

// func servicemain(argc uint32, argv **uint16)
TEXT ·servicemain(SB),7,$0
	MOVL	CX, ·sArgc(SB)
	MOVL	DX, ·sArgv(SB)
@gopherbot gopherbot added this to the Unreleased milestone Mar 28, 2018
@tklauser tklauser added OS-Windows NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Mar 28, 2018
@tklauser
Copy link
Member

/cc @alexbrainman

@alexbrainman
Copy link
Member

I am pretty sure this is a bug. But I would like to write a test before I fix this. I will try and do this when I have time.

Thank you.

Alex

@gopherbot
Copy link

Change https://golang.org/cl/110160 mentions this issue: windows/svc: correct MOVL instruction in sys_amd64.s

@zhangyoufu
Copy link
Contributor Author

@gopherbot please consider this for backport to 1.10.3

@gopherbot
Copy link

Backport issue(s) opened: #25200 (for 1.10).

Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://golang.org/wiki/MinorReleases.

@gopherbot gopherbot mentioned this issue May 1, 2018
Closed
@katiehockman
Copy link
Contributor

@alexbrainman @zhangyoufu Can you please clarify why this should be considered for backport? Per https://github.com/golang/go/wiki/MinorReleases it should be either a regression, security issue, or serious problem with no workaround.

@alexbrainman
Copy link
Member

Can you please clarify why this should be considered for backport?

I do not think this fix needs to be backported. How do we backport golang.org/x/sys repo?

Alex

@katiehockman
Copy link
Contributor

Thanks, I'll close the backport issue then.

For future backports, the process is the same as it is for the go repo. It looks like golang.org/x/sys has a go1.11 release branch (https://go.googlesource.com/sys), so we would just cherry pick to that branch per the instructions here: https://github.com/golang/go/wiki/MinorReleases#making-cherry-pick-cls

@alexbrainman
Copy link
Member

For future backports, the process is the same as it is for the go repo. It looks like golang.org/x/sys has a go1.11 release branch

Fair enough, I did not know that. It is not surprising, I live on bleeding edge :-)

Alex

@golang golang locked and limited conversation to collaborators Oct 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Windows
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@tklauser @zhangyoufu @gopherbot @alexbrainman @katiehockman