Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: enhance trybot's successful run report #24539

Closed
hyangah opened this issue Mar 26, 2018 · 3 comments
Closed

x/build: enhance trybot's successful run report #24539

hyangah opened this issue Mar 26, 2018 · 3 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Milestone

Comments

@hyangah
Copy link
Contributor

hyangah commented Mar 26, 2018

Upon successful run, let TryBots say more than they are happy.
For example, the list of trybots who participated.

Background:
https://go-review.googlesource.com/c/go/+/101736 caused build failures in all mac os builders.
That was quite surprising because previous trybot runs didn't report the issue.
Since we don't hold the logs of successful trybots run, the trybot run log is unavailable for inspection either.

  1. Would be great if we can record the successful trybot run logs much longer.
  2. If that's not ideal, include a bit more details in the trybot's result report comment such as list of trybots that run the tests.
@gopherbot gopherbot added this to the Unreleased milestone Mar 26, 2018
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Mar 26, 2018
@andybons
Copy link
Member

This is in the works, as it's a prerequisite to having a UI in Gerrit that shows the progress and success of trybot runs. I'm not sure if there's already an issue on file. /cc @bradfitz

@andybons andybons self-assigned this Mar 26, 2018
@josharian
Copy link
Contributor

See also #19327

@dmitshur
Copy link
Contributor

I'll fold this into #34119 if you don't mind. We've decided there this is something we want to implement, so it's just a matter of time.

@andybons andybons removed their assignment Sep 18, 2019
@golang golang locked and limited conversation to collaborators Sep 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Projects
None yet
Development

No branches or pull requests

5 participants