Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/playground: clean up the common code in handleVet and handleCompile #24535

Closed
ysmolski opened this issue Mar 26, 2018 · 2 comments
Closed

x/playground: clean up the common code in handleVet and handleCompile #24535

ysmolski opened this issue Mar 26, 2018 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@ysmolski
Copy link
Member

ysmolski commented Mar 26, 2018 •
edited

After the work on adding vet in #7597 there is a need to clean up the common code between handleVet and handleCompile. These handlers are almost identical.

Introduce some general handleCommand function.
@gopherbot gopherbot added this to the Unreleased milestone Mar 26, 2018
@ysmolski ysmolski changed the title x/playground: clean up code shared in handlers x/playground: clean up the common code in handleVet and handleCompile Mar 26, 2018
@andybons andybons added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 26, 2018
@gopherbot
Copy link

Change https://golang.org/cl/112795 mentions this issue: playground: refactor handleVet and handleCompile methods

@ysmolski
Copy link
Member Author

@andybons and @bcmills, please take a look.

@golang golang locked and limited conversation to collaborators May 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@ysmolski @andybons @gopherbot