Skip to content

x/crypto/argon2: Add AVX2 implementation #24519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
aead opened this issue Mar 24, 2018 · 1 comment
Open

x/crypto/argon2: Add AVX2 implementation #24519

aead opened this issue Mar 24, 2018 · 1 comment
Labels
NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. Proposal-Crypto Proposal related to crypto packages or other security issues
Milestone
Unreleased

Comments

@aead
Copy link
Contributor

aead commented Mar 24, 2018 •
edited
Loading

This is a feature request for adding an AVX2 implementation of Argon2. Currently there is a generic / pure Go and an amd64 SSE4.1 implementation.
An AVX2 implementation can improve performance about ~30 %. The AVX2 implementation requires Go 1.10 because of some instructions which are not supported by the assembler in earlier releases.

See also: google/fscrypt#82

/cc @FiloSottile
@gopherbot gopherbot added this to the Unreleased milestone Mar 24, 2018
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/102422 mentions this issue: argon2: add AVX2 implementation

@andybons andybons added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 26, 2018
@ALTree ALTree added NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. Proposal-Crypto Proposal related to crypto packages or other security issues and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. Proposal-Crypto Proposal related to crypto packages or other security issues
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@andybons @ALTree @gopherbot @aead