x/mobile/cmd/gomobile: fail to `gomobile build` as "not a valid go package name" #24511

hajimehoshi · 2018-03-23T18:15:39Z

What version of Go are you using (`go version`)?

go version go1.10 darwin/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (`go env`)?

GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/hajimehoshi/Library/Caches/go-build"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/hajimehoshi/go"
GORACE=""
GOROOT="/usr/local/go"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/7t/qw3np69559591s1v0mk5_p1m0000gn/T/go-build549033053=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

Create $GOPATH/src/github.com/hajimehoshi/12345 (the last directory name is invalid as a package name)
Create $GOPATH/github.com/hajimehoshi/12345/main.go like

package main

import _ "golang.org/x/mobile/app"

func main() {}

Run gomobile build github.com/hajimehoshi/12345

What did you expect to see?

Build succeed

What did you see instead?

panic: package name "12345" is not a valid go package name

goroutine 1 [running]:
main.androidPkgName(0x7ffeefbff8a6, 0x5, 0x7ffeefbff8a6, 0x5)
        /Users/hajimehoshi/go/src/golang.org/x/mobile/cmd/gomobile/build_androidapp.go:296 +0xeeb
main.goAndroidBuild(0xc420188a80, 0xc42009d280, 0x4, 0x4, 0x0, 0x0, 0x0)
        /Users/hajimehoshi/go/src/golang.org/x/mobile/cmd/gomobile/build_androidapp.go:32 +0x139
main.runBuild(0x1672960, 0x0, 0x0)
        /Users/hajimehoshi/go/src/golang.org/x/mobile/cmd/gomobile/build.go:109 +0x4d4
main.main()
        /Users/hajimehoshi/go/src/golang.org/x/mobile/cmd/gomobile/main.go:73 +0x34e

The text was updated successfully, but these errors were encountered:

AlexRouSg · 2018-03-23T18:30:19Z

https://developer.android.com/guide/topics/manifest/manifest-element.html#package

The name may contain uppercase or lowercase letters ('A' through 'Z'), numbers, and underscores ('_'). However, individual package name parts may only start with letters.

You cannot have a package named 12345 on android.

hajimehoshi · 2018-03-23T18:39:25Z

The package name for Android is automatically generated by gomobile build based on the Go package path, and I don't think this is gomobile user's responsibility.

AlexRouSg · 2018-03-23T19:00:59Z

Sorry, I tried to compile a normal go package named 12345 and that failed too. So this isn't related to gomobile.

From reading the spec https://golang.org/ref/spec it described that package names must start with a letter.

A package clause begins each source file and defines the package to which the file belongs.

PackageClause = "package" PackageName .
PackageName = identifier .

Identifiers name program entities such as variables and types. An identifier is a sequence of one or more letters and digits. The first character in an identifier must be a letter.

identifier = letter { letter | unicode_digit } .

hajimehoshi · 2018-03-23T19:13:18Z

Package path github.com/hajimehoshi/12345 is legal and its 'package name' is actually main.

AlexRouSg · 2018-03-23T19:19:01Z

/cc @hyangah

hajimehoshi · 2018-03-26T15:42:54Z

b39ed682d87b8df3698bcbc8fbaff91efbaa9d17

The package name for android is determined at androidPkgName. This should be easy to fix after determining how to fix this.

hajimehoshi · 2018-03-26T15:54:44Z

I've created a change,

diff --git a/cmd/gomobile/build_androidapp.go b/cmd/gomobile/build_androidapp.go
index a1f07cb..b4629b1 100644
--- a/cmd/gomobile/build_androidapp.go
+++ b/cmd/gomobile/build_androidapp.go
@@ -287,20 +287,15 @@ func goAndroidBuild(pkg *build.Package, androidArchs []string) (map[string]bool,
 // but not exactly same.
 func androidPkgName(name string) string {
        var res []rune
-       for i, r := range name {
+       for _, r := range name {
                switch {
-               case 'a' <= r && r <= 'z', 'A' <= r && r <= 'Z':
-                       res = append(res, r)
-               case '0' <= r && r <= '9':
-                       if i == 0 {
-                               panic(fmt.Sprintf("package name %q is not a valid go package name", name))
-                       }
+               case 'a' <= r && r <= 'z', 'A' <= r && r <= 'Z', '0' <= r && r <= '9':
                        res = append(res, r)
                default:
                        res = append(res, '_')
                }
        }
-       if len(res) == 0 || res[0] == '_' {
+       if len(res) == 0 || res[0] == '_' || ('0' <= res[0] && res[0] <= '9') {
                // Android does not seem to allow the package part starting with _.
                res = append([]rune{'g', 'o'}, res...)
        }
diff --git a/cmd/gomobile/build_test.go b/cmd/gomobile/build_test.go
index b09a167..e89764c 100644
--- a/cmd/gomobile/build_test.go
+++ b/cmd/gomobile/build_test.go
@@ -54,6 +54,7 @@ func TestAndroidPkgName(t *testing.T) {
                {".-.", "go___"},
                {"abstract", "abstract_"},
                {"Abstract", "Abstract"},
+               {"12345", "go12345"},
        }
 
        for _, tc := range tests {

but git codereview mail fails with:

remote: The push has been rejected because we detect that it contains a private
remote: key. Please check the following commands and confirm that it's
remote: intentional:
remote:
remote:     git show b4629b1170079341fbc8a53a1f72c4e964687a01
remote:
remote: You can use `git rev-list --objects --all` to find the files.
remote:
remote: To push these files, please run `git push -o nokeycheck`.
remote:
To https://go.googlesource.com/mobile
 ! [remote rejected] HEAD -> refs/for/master (found a private key)
error: failed to push some refs to 'https://go.googlesource.com/mobile'
(running: git push -q origin HEAD:refs/for/master)
/Users/hajimehoshi/go/bin/git-codereview: exit status 1

🤔

hajimehoshi · 2018-03-26T16:08:29Z

https://go-review.googlesource.com/c/mobile/+/102576

git push -o nokeycheck origin HEAD:refs/for/master solved that (https://groups.google.com/forum/#!topic/golang-dev/huoCHVWVufQ)

hajimehoshi · 2018-03-27T05:15:20Z

It's fixed (the gobot doesn't notify this, but I think this is because my git-push way is special)

dmitshur · 2018-03-27T18:52:03Z

the gobot doesn't notify this, but I think this is because my git-push way is special

It was because of https://go-review.googlesource.com/c/mobile/+/102576/4//COMMIT_MSG#15.

gopherbot added this to the Unreleased milestone Mar 23, 2018

gopherbot added the mobile Android, iOS, and x/mobile label Mar 23, 2018

dmitshur changed the title ~~x/mobile/cmd/mobile: fail to gomobile build as "not a valid go package name"~~ x/mobile/cmd/gomobile: fail to gomobile build as "not a valid go package name" Mar 24, 2018

hajimehoshi closed this as completed Mar 27, 2018

golang locked and limited conversation to collaborators Mar 27, 2019

gopherbot added the FrozenDueToAge label Mar 27, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

x/mobile/cmd/gomobile: fail to `gomobile build` as "not a valid go package name" #24511

x/mobile/cmd/gomobile: fail to `gomobile build` as "not a valid go package name" #24511

hajimehoshi commented Mar 23, 2018

AlexRouSg commented Mar 23, 2018

hajimehoshi commented Mar 23, 2018 •

edited

AlexRouSg commented Mar 23, 2018

hajimehoshi commented Mar 23, 2018

AlexRouSg commented Mar 23, 2018

hajimehoshi commented Mar 26, 2018

hajimehoshi commented Mar 26, 2018 •

edited

hajimehoshi commented Mar 26, 2018

hajimehoshi commented Mar 27, 2018

dmitshur commented Mar 27, 2018

x/mobile/cmd/gomobile: fail to gomobile build as "not a valid go package name" #24511

x/mobile/cmd/gomobile: fail to gomobile build as "not a valid go package name" #24511

Comments

hajimehoshi commented Mar 23, 2018

What version of Go are you using (go version)?

Does this issue reproduce with the latest release?

What operating system and processor architecture are you using (go env)?

What did you do?

What did you expect to see?

What did you see instead?

AlexRouSg commented Mar 23, 2018

hajimehoshi commented Mar 23, 2018 • edited

AlexRouSg commented Mar 23, 2018

hajimehoshi commented Mar 23, 2018

AlexRouSg commented Mar 23, 2018

hajimehoshi commented Mar 26, 2018

hajimehoshi commented Mar 26, 2018 • edited

hajimehoshi commented Mar 26, 2018

hajimehoshi commented Mar 27, 2018

dmitshur commented Mar 27, 2018

x/mobile/cmd/gomobile: fail to `gomobile build` as "not a valid go package name" #24511

x/mobile/cmd/gomobile: fail to `gomobile build` as "not a valid go package name" #24511

What version of Go are you using (`go version`)?

What operating system and processor architecture are you using (`go env`)?

hajimehoshi commented Mar 23, 2018 •

edited

hajimehoshi commented Mar 26, 2018 •

edited