x/crypto/acme: Set a meaningful user-agent #24496
Comments
|
Ideally there would also be a mechanism for downstream libraries to tack on their own name and version. For instance, https://github.com/jetstack/kube-lego uses |
titanous
added
the
NeedsFix
|
Change https://golang.org/cl/86635 mentions this issue: |
|
Hi, friendly ping on this? Thanks! |
Fixes golang/go#21081 Fixes golang/go#24496 Change-Id: I56e624bcf5a85bd6c360fd97e0e9f6c2536430ac
|
Change https://golang.org/cl/183267 mentions this issue: |
|
Change https://golang.org/cl/198538 mentions this issue: |
This is useful to CAs, to identify and reach out to problematic clients. Fixes golang/go#24496 Change-Id: I944fc8178c8fa8acaf3854e9c125d3af0364a4fb Reviewed-on: https://go-review.googlesource.com/c/crypto/+/183267 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This is useful to CAs, to identify and reach out to problematic clients. Fixes golang/go#24496 Change-Id: I944fc8178c8fa8acaf3854e9c125d3af0364a4fb Reviewed-on: https://go-review.googlesource.com/c/crypto/+/183267 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This is useful to CAs, to identify and reach out to problematic clients. Fixes golang/go#24496 Change-Id: I944fc8178c8fa8acaf3854e9c125d3af0364a4fb Reviewed-on: https://go-review.googlesource.com/c/crypto/+/183267 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This is useful to CAs, to identify and reach out to problematic clients. Fixes golang/go#24496 Change-Id: I944fc8178c8fa8acaf3854e9c125d3af0364a4fb Reviewed-on: https://go-review.googlesource.com/c/crypto/+/183267 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This is useful to CAs, to identify and reach out to problematic clients. Fixes golang/go#24496 Change-Id: I944fc8178c8fa8acaf3854e9c125d3af0364a4fb Reviewed-on: https://go-review.googlesource.com/c/crypto/+/183267 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This is useful to CAs, to identify and reach out to problematic clients. Fixes golang/go#24496 Change-Id: I944fc8178c8fa8acaf3854e9c125d3af0364a4fb Reviewed-on: https://go-review.googlesource.com/c/crypto/+/183267 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
The x/crypto/acme package does not provide a User-Agent, defaulting to "Go-http-client/1.1". This makes it hard to distinguish between requests from x/crypto/acme and other Go implementations. The ACME spec recommends setting a meaningful User-Agent string, including the library version.
Ideally this would look something like:
User-Agent: Go-acme/1.2.3However, since packages under
xaren't explicitly versioned as far as I know, this could be tricky. Perhaps the maintainer could choose a starting version to be stored in a package-level variable, and bumped on major changes? My goal is for ACME server maintainers to be able to look at access logs for misbehaving clients and determine which library produced those requests, in order to contact the maintainers and request a fix. Additionally, it would be nice to be able to tell roughly which version of the library produced the requests, so the server maintainer can tell whether the requests are caused by a known issue or a new one.The text was updated successfully, but these errors were encountered: