Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/internal/obj/arm64: assembler handles negative offset for LDP incorrectly. #24471

Closed
zhangfannie opened this issue Mar 21, 2018 · 2 comments
Closed

cmd/internal/obj/arm64: assembler handles negative offset for LDP incorrectly. #24471

zhangfannie opened this issue Mar 21, 2018 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.11

Comments

@zhangfannie
Copy link
Contributor

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

go version devel +ae10914 Tue Mar 20 09:44:50 2018 +0000 linux/arm64

Does this issue reproduce with the latest release?

yes

What operating system and processor architecture are you using (go env)?

GOARCH="arm64"
GOBIN=""
GOCACHE="/home/fanzha02/.cache/go-build"
GOEXE=""
GOHOSTARCH="arm64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/fanzha02/go"
GORACE=""
GOROOT="/mnt/share/homes/fanzha02/RefineAsm/golang"
GOTMPDIR=""
GOTOOLDIR="/mnt/share/homes/fanzha02/RefineAsm/golang/pkg/tool/linux_arm64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build687545391=/tmp/go-build -gno-record-gcc-switches"

What did you do?

  1. add a test case " LDP -31(R0), (R1, R2)" in cmd/asm/internal/asm/arm64.s file,
  2. run command "go test ".

If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.

What did you expect to see?

pass the test

What did you see instead?

The assembler reports the error.
"endtoend_test.go:186: invalid offset 01064 (testdata/arm64.s:461) LDP -31(R0), (R1, R2)"
@zhangfannie
Copy link
Contributor Author

Fixed patch will be submitted soon.

@andybons andybons added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 21, 2018
@andybons andybons added this to the Go1.11 milestone Mar 21, 2018
@gopherbot
Copy link

Change https://golang.org/cl/102635 mentions this issue: cmd/internal/obj/arm64: fix the bug of incorrect handling negative offset of LDP

@golang golang locked and limited conversation to collaborators Apr 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.11
Development

No branches or pull requests
3 participants
@andybons @gopherbot @zhangfannie