Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/website: addressing inaccessible links on CN site #24457

Open
adamyi opened this issue Mar 20, 2018 · 4 comments
Open

x/website: addressing inaccessible links on CN site #24457

adamyi opened this issue Mar 20, 2018 · 4 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@adamyi
Copy link

adamyi commented Mar 20, 2018

Many of the external links on golang.google.cn are inaccessible from Mainland China (e.g. *.golang.org, *.blogspot.com, *.googlesource.com), which might cause some troubles for Chinese developers.

Directly removing all inaccessible links would lead to situations like: "For more details, please check out this post" (while there isn't a link, nor is it clear which post it is). Instead, we can keep those links and automatically render a tooltip for blacklisted URLs that is shown if you put your mouse over it (a hover overlay, actually already implemented in the DevSite infrastructure. For instance tensorflow.google.cn, put mouse over the Google logo in the company list to test)

The other route we could take is to separate files, like go_faq.zh.html, and let them slowly be translated by the community. It would be nice to have Chinese translations in the future. We'd have to remember to add content to both in the future, though.

See the discussion on https://go-review.googlesource.com/c/go/+/89215 for more context.

/cc @chenglu for checking CN site policies @andybons @bradfitz

@adamyi adamyi changed the title doc: inaccessible external links on CN site proposal: doc: addressing inaccessible links on CN site Mar 20, 2018
@gopherbot gopherbot added this to the Proposal milestone Mar 20, 2018
@ALTree
Copy link
Member

ALTree commented Mar 20, 2018

This is not really a "proposal"

The proposal process should be used for any notable change or addition to the language, libraries and tools.

I've changed this to a plain issue and added a NeedsDecision label.

@ALTree ALTree changed the title proposal: doc: addressing inaccessible links on CN site website: addressing inaccessible links on CN site Mar 20, 2018
@ALTree ALTree added NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. and removed Documentation Proposal labels Mar 20, 2018
@mengzhuo
Copy link
Contributor

-1
No, I don't think it's a problem for Chinese developers.

@crvv
Copy link
Contributor

crvv commented Mar 20, 2018

I agree that it isn't a problem for developers.
But I don't know whether the PRC government will be angry about those links.
Maybe Google want to remove those links only to reduce trouble.

@mvdan mvdan modified the milestones: Proposal, Unreleased Mar 20, 2018
@andybons andybons self-assigned this Mar 20, 2018
@andybons andybons added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. and removed NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. labels Mar 20, 2018
@andybons
Copy link
Member

andybons commented Mar 20, 2018

We'll be revamping our web site soon. Let's revisit this when that effort starts in earnest.

@andybons andybons removed their assignment Sep 18, 2019
@seankhliao seankhliao changed the title website: addressing inaccessible links on CN site x/website: addressing inaccessible links on CN site Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

7 participants