Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: 9 is listed as a prime in example code within spec #24451

Closed
go101 opened this issue Mar 19, 2018 · 5 comments
Closed

doc: 9 is listed as a prime in example code within spec #24451

go101 opened this issue Mar 19, 2018 · 5 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.11

Comments

@go101
Copy link

go101 commented Mar 19, 2018 •
edited 

primes := []int{2, 3, 5, 7, 9, 2147483647}

9 is not a prime.
@gopherbot
Copy link

Change https://golang.org/cl/101457 mentions this issue: doc: remove non-prime from list of primes in spec

@andybons andybons added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 19, 2018
@andybons andybons added this to the Go1.11 milestone Mar 19, 2018
@dgryski
Copy link
Contributor

dgryski commented Mar 19, 2018

Previously #2870

@gopherbot
Copy link

Change https://golang.org/cl/101495 mentions this issue: Revert "doc: remove non-prime from list of primes in spec"

@andybons andybons changed the title spec: an imperfect example doc: 9 is listed as a prime in example code within spec Mar 19, 2018
@andybons
Copy link
Member

For posterity:

It's a reference to a legendary article from the Journal of Irreproducible Results.

— @robpike

gopherbot pushed a commit that referenced this issue Mar 19, 2018
@andybons
Revert "doc: remove non-prime from list of primes in spec"
7974f08 
This reverts commit 4b06d9d.

Reason for revert: It's a reference to a legendary article
from the Journal of Irreproducible Results.

Updates #24451

Change-Id: I0288177f4e286bd6ace5774f2e5e0acb02370305
Reviewed-on: https://go-review.googlesource.com/101495
Reviewed-by: Andrew Bonventre <andybons@golang.org>
@go101
Copy link
Author

go101 commented Mar 20, 2018

great reads: #8830 #10892 http://en.wikipedia.org/wiki/Paul_Erd%C5%91s (esp. the last one)

@golang golang locked and limited conversation to collaborators Mar 20, 2019
imryao pushed a commit to imryao/biscuit that referenced this issue Mar 15, 2023
@andybons @imryao
doc: remove non-prime from list of primes in spec
5348418 
Fixes golang/go#24451

Change-Id: Id9b4cbd1a1ff032f1cc4606e9734ddcc64892ae5
Reviewed-on: https://go-review.googlesource.com/101457
Reviewed-by: Filippo Valsorda <filippo@golang.org>
(cherry picked from commit 4b06d9d72747b0407e2cd9a423b689c7e9c8e92d)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.11
Development

No branches or pull requests
4 participants
@andybons @dgryski @gopherbot @go101